Summary: | ASTERISK-26529: [UBSAN] codec_adpcm.c: runtime error: left shift of negative value -4 | ||
Reporter: | Badalian Vyacheslav (slavon) | Labels: | |
Date Opened: | 2016-10-30 13:59:42 | Date Closed: | 2016-10-30 14:32:05 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | |
Versions: | 13.12.1 14.1.1 GIT | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ||
Description: | {code}
codec_adpcm.c:151:23: runtime error: left shift of negative value -4 #0 0x7fe47d1753b0 (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x53b0) #1 0x7fe47d175673 (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x5673) #2 0x7fe47d1762cb (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x62cb) #3 0x962eca in generate_computational_cost /usr/src/asterisk/main/translate.c:674 #4 0x96857e in __ast_register_translator /usr/src/asterisk/main/translate.c:1217 #5 0x7fe47d17667d (/tmp/asterisk-testsuite/86ef220a01cc7fa06596ddd595bec9bf/run_1/ast1/usr/lib/asterisk/modules/codec_adpcm.so+0x667d) #6 0x76089c in start_resource /usr/src/asterisk/main/loader.c:1029 #7 0x763941 in load_resource_list /usr/src/asterisk/main/loader.c:1293 #8 0x764e6e in load_modules /usr/src/asterisk/main/loader.c:1454 #9 0x4bf34f in asterisk_daemon /usr/src/asterisk/main/asterisk.c:4616 #10 0x4be642 in main /usr/src/asterisk/main/asterisk.c:4373 #11 0x7fe4ad989b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) #12 0x433918 (/usr/sbin/asterisk+0x433918) {code} {code} root@0bfa9456f68a:/usr/src/asterisk# git log commit 6b1c55dc9be90904363dbcf958a9fcc243c85629 Author: George Joseph <gjoseph@digium.com> Date: Fri Oct 28 15:59:19 2016 -0600 pjproject_bundled: Fix issue where "/version.mak" wasn't found root@0bfa9456f68a:/usr/src/asterisk# git branch * 13 {code} on module load... | ||
Comments: | By: Asterisk Team (asteriskteam) 2016-10-30 13:59:42.482-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Corey Farrell (coreyfarrell) 2016-10-30 14:32:05.399-0500 This is not necessarily a bug. Left shift of a negative value may not make sense from human mathematical rules, but that doesn't automatically make it invalid for a computer algorithm. For this ticket to be reopened I would want to see a reproducible example of the codec translation introducing an audio problem (distortion, clicks, change of audio tone). Without proof of a real world problem the risk of changing this is too high. |