Summary:	ASTERISK-26568: pbx_spool: OUTGOING_RETRY variable
Reporter:	Roman Shubovich (rom1kz)	Labels:
Date Opened:	2016-11-08 18:37:10.000-0600	Date Closed:	2017-03-09 14:30:08.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	PBX/pbx_spool
Versions:	13.12.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	i have proposal for new variable in module pbx_spool when call out retry occurred module sets the variable OUTGOING_RETRY after that you can do any retry-specific logic in you dialplan
Comments:	By: Asterisk Team (asteriskteam) 2016-11-08 18:37:11.516-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2016-11-10 18:14:36.996-0600 Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines [2] * Review the Code Review Checklist [3] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4] * As this is a new feature, please read the New Feature Guidelines [5] * Make sure your new feature applies cleanly to Asterisk trunk When ready, submit your patch and any tests to Gerrit [6] for code review. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines [3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist [4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation [5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines [6] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Rusty Newton (rnewton) 2016-11-10 18:16:27.947-0600 Why is your patch named res_config_pgsql.c , when you are patching pbx_spool.c ? Scan through the code review and new feature guidelines, then submit your patch to Gerrit. Others will review it at that point. By: Roman Shubovich (rom1kz) 2016-11-10 18:32:50.960-0600 sorry for the mistake of course, name of the file should be pbx_spool.c.patch By: Rusty Newton (rnewton) 2016-11-10 18:34:44.101-0600 No worries. I went ahead and removed your patch so that you can reattach it with an appropriate name, and additionally you need to be sure that you mark it as a contribution. Thanks! By: Rusty Newton (rnewton) 2016-11-11 09:03:35.286-0600 I've removed your patch again, as you didn't follow my request. bq. No worries. I went ahead and removed your patch so that you can reattach it with an appropriate name, and additionally you need to be sure that you mark it as a contribution. Thanks! Please sign the license agreement and mark the attachment as a contribution when you re-attach the patch. https://issues.asterisk.org/jira/secure/DigiumLicense.jspa By: Asterisk Team (asteriskteam) 2016-11-25 12:00:01.423-0600 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Friendly Automation (friendly-automation) 2017-03-09 14:30:09.173-0600 Change 5132 merged by Joshua Colp: pbx_spool: Set AST_OUTGOING_ATTEMPT variable on channel [https://gerrit.asterisk.org/5132|https://gerrit.asterisk.org/5132]