Summary:	ASTERISK-26573: Some typos in documentation of chan_sip.c
Reporter:	C.J. Collier (cjcollier)	Labels:
Date Opened:	2016-11-09 16:41:30.000-0600	Date Closed:	2016-11-10 23:46:51.000-0600
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:	14.1.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	All	Attachments:
Description:	I'm reviewing the code to determine how best to go about implementing the Proxy-Require feature requested by my hard phones.  While doing so, I've seen a few typos which could be addressed. I have signed the contributor license agreement and will submit my changes with gerrit at such time as my agreement is accepted.
Comments:	By: Asterisk Team (asteriskteam) 2016-11-09 16:41:31.376-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2016-11-10 13:35:36.701-0600 Thanks. I've opened up the issue. Remember to reference this issue in your commit message so that it'll be linked. By: C.J. Collier (cjcollier) 2016-11-10 14:15:18.906-0600 https://gerrit.asterisk.org/#/c/4380/ By: C.J. Collier (cjcollier) 2016-11-10 14:20:23.188-0600 While doing the review, I found that the chan_sip is deprecated with chan_pjsip being the core supported SIP functionality going forward.  And fortunately, chan_pjsip has support for adding functionality through modules. By: Rusty Newton (rnewton) 2016-11-10 18:38:39.136-0600 chan_sip *is not deprecated*, it is under "extended support" instead of "core support".  Development work is focused on res_pjsip/chan_pjsip, that is correct. Here is the [wiki page about module support states|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Module+Support+States]. By: Friendly Automation (friendly-automation) 2016-11-10 23:46:51.890-0600 Change 4380 merged by zuul: chan_sip: Fix typo and re-wrap surrounding docs [https://gerrit.asterisk.org/4380|https://gerrit.asterisk.org/4380]