Summary:	ASTERISK-26584: [patch] RTCP feedback for codec modules
Reporter:	Lorenzo Miniero (lminiero)	Labels:
Date Opened:	2016-11-11 17:59:41.000-0600	Date Closed:	2017-01-27 07:05:45.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General Resources/res_rtp_asterisk
Versions:	14.1.2	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) rtcp-feedback.diff
Description:	This patch addresses the discussion I started on asterisk-dev [1] about possible strategies to allow codec modules to receive RTCP feedback from the Asterisk RTP stack. More specifically, this patch introduces a new ast_frame type (AST_FRAME_RTCP) and a new callback (feedback) codec modules can implement to be notified about RTCP feedback relevant to an encoder. [1] http://lists.digium.com/pipermail/asterisk-dev/2016-November/075923.html
Comments:	By: Asterisk Team (asteriskteam) 2016-11-11 17:59:41.760-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Lorenzo Miniero (lminiero) 2016-11-11 18:02:06.897-0600 First version of the patch, originally published here: http://lists.digium.com/pipermail/asterisk-dev/2016-November/075948.html Next steps: passing the frame to the feedback callback (if any) to all translators in the list, and actually using the feedback in a real codec (e.g., speex) as a proof of concept. By: Rusty Newton (rnewton) 2016-11-13 09:21:29.018-0600 If you are looking to get reviews on an early version that isn't ready to be merged, go ahead and submit the review to Gerrit on Master and just add a note to let people know you don't want it merged yet. You probably won't get any reviews if it is only on JIRA. [~jcolp] , [~gjoseph], I'm going to ping a couple of core developers just in case I'm telling you wrong. By: George Joseph (gjoseph) 2016-11-13 20:38:55.491-0600 The best way to get a pre-review is to prefix the title line of the commit with "RFC" (request for comments) and submit to Gerrit.  When it's ready, you can just remove the "RFC" prefix. By: Lorenzo Miniero (lminiero) 2016-11-13 20:46:37.182-0600 Thanks for the feedback, I was not aware of Gerrit. I'm currently abroad for a conference, I'll probably take care of this when I get back next week, or before that if I can. By: Joshua C. Colp (jcolp) 2016-11-14 06:03:14.185-0600 I'll assign this to you until you've got it up onto Gerrit. By: Rusty Newton (rnewton) 2016-11-14 14:17:54.033-0600 [~lminiero] here is the wiki page about Gerrit usage for our project: https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage Please don't hesitate to contact us on irc.freenode.net #asterisk-dev if you need help working with Gerrit or E-mail asteriskteam@digium.com. By: Lorenzo Miniero (lminiero) 2016-11-29 09:34:27.222-0600 I *think* I did it, hopefully I didn't mess anything up: https://gerrit.asterisk.org/#/c/4519/ Sorry if this took so long, but I only recently came back from abroad. By: Joshua C. Colp (jcolp) 2016-11-29 09:37:13.447-0600 Unfortunately it does not currently build in dev mode. If you check the links that Jenkins added you can go to Console Output and see where/why. By: Lorenzo Miniero (lminiero) 2016-11-29 10:00:20.374-0600 Apparently an ISO C90 warning on mixed declarations. I should have fixed those. By: Lorenzo Miniero (lminiero) 2016-11-29 10:17:47.732-0600 I fixed another issue Jenkins spotted, but apparently now I ended up with two additional Gerrit pages (4520, 4521) instead of updates to the one I already had? I did use the "git review -s" command to install the hooks required for Change-Id mapping, so that should work, did I do something wrong? By: Friendly Automation (friendly-automation) 2017-01-27 07:05:46.794-0600 Change 4614 merged by George Joseph: media: Add experimental support for RTCP feedback. [https://gerrit.asterisk.org/4614|https://gerrit.asterisk.org/4614]