Summary:	ASTERISK-26610: Alembic script for voicemail does not create columns for all options available in voicemail.conf
Reporter:	Jeff Clay (Jeff_C)	Labels:
Date Opened:	2016-11-17 10:58:39.000-0600	Date Closed:	2016-11-29 17:39:05.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	PBX/pbx_realtime
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	The alembic script for voicemail does not create columns for all options available in voicemail.conf.sample (https://github.com/asterisk/asterisk/blob/master/configs/samples/voicemail.conf.sample) nor does it create the same columns as previously available in past voicemail table sql scripts such as 'saydurationm' and 'hidefromdir'
Comments:	By: Asterisk Team (asteriskteam) 2016-11-17 10:58:40.261-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Rusty Newton (rnewton) 2016-11-23 15:00:16.791-0600 When it was added, only the commonly used config options were included. This issue would be considered an improvement or feature request, so if you want to submit a patch, that would be the best way to get the options you want added in. If you would like to submit a revision for alembic to add this it would be appreciated. Details are in the Alembic[1] documentation for how to create a revision and an existing revision can be used to determine what to do. If you have any questions feel free to ask, and the contribution process is the first comment on this issue. [1] http://alembic.zzzcomputing.com/en/latest/tutorial.html#create-a-migration-script And, the documentation for using our Gerrit instance is here: https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Jeff Clay (Jeff_C) 2016-11-28 10:07:50.798-0600 Thanks Rusty. I know in the past there has been an issue where config options in various files were no longer valid and being used by the * code. Is there a way to check for this and also the max value length accepted by the code? I just want to make sure that any changes made to db columns will reflect valid settings. By: Rusty Newton (rnewton) 2016-11-28 13:12:00.686-0600 The easiest way to validate each config option would be to look at the source code. If you run into confusion, you could ask about specific options [on the dev list|http://lists.digium.com/mailman/listinfo/asterisk-dev] and someone should be able to help. By: Jeff Clay (Jeff_C) 2016-11-29 16:06:53.689-0600 This is going to take more time than I have right now. This issue can be closed. I will reference the docs and open a new improvement with a patch to address many other alembic changes I've found. Thanks By: Rusty Newton (rnewton) 2016-11-29 17:39:05.961-0600 Sounds good. Closing out for now.