Summary:	ASTERISK-26614: app_queue: updatecdr option in queues.conf does effectively nothing
Reporter:	Alexander Gonchiy (alexander.gonchiy)	Labels:
Date Opened:	2016-11-20 09:13:50.000-0600	Date Closed:	2021-03-25 08:37:01
Priority:	Minor	Regression?	Yes
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:	13.12.2 14.1.2	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	updatecdr option, documented in queues.conf.sample configuration file is useless, because since version 12 app_queue.c source file does not have the code that would use the update_cdr variable, set by said option. It seems that removal of updatecdr and many other options from agents.conf in version 12 also introduced the regression - update_cdr variable is still set in app_queue.c, but never used anywhere in source code.
Comments:	By: Asterisk Team (asteriskteam) 2016-11-20 09:13:51.772-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Matt Jordan (mjordan) 2017-03-14 10:12:07.299-0500 This isn't really a bug so much as an oversight in documentation: # {{chan_agent}} is dead, and so is mimicing its behavior # CDRs generally don't allow you to modify the read-only fields any longer. Hence, we no longer allow you to update the {{dstchannel}} from any where. By: Friendly Automation (friendly-automation) 2021-03-25 08:37:02.940-0500 Change 15693 merged by Friendly Automation: app_queue.c: Remove dead 'updatecdr' code. [https://gerrit.asterisk.org/c/asterisk/+/15693|https://gerrit.asterisk.org/c/asterisk/+/15693] By: Friendly Automation (friendly-automation) 2021-03-25 08:37:45.880-0500 Change 15692 merged by Joshua Colp: app_queue.c: Remove dead 'updatecdr' code. [https://gerrit.asterisk.org/c/asterisk/+/15692|https://gerrit.asterisk.org/c/asterisk/+/15692] By: Friendly Automation (friendly-automation) 2021-03-25 08:38:56.020-0500 Change 15680 merged by Joshua Colp: app_queue.c: Remove dead 'updatecdr' code. [https://gerrit.asterisk.org/c/asterisk/+/15680|https://gerrit.asterisk.org/c/asterisk/+/15680]