Summary:	ASTERISK-26638: res_clioriginate: originate Local always creates channel with slin 8khz format
Reporter:	Vitaly K (bg1)	Labels:
Date Opened:	2016-12-03 21:46:43.000-0600	Date Closed:
Priority:	Major	Regression?
Status:	Open/New	Components:	Resources/res_clioriginate
Versions:	13.4.0 14.2.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	any	Attachments:
Description:	For example you want to create outgoing channel and play some file for tests You run something like asterisk>  channel originate Local/s@contextA application Playback file_wav16 and you listen poor voice quality with compare of incoming call to context which do Playback( file_wav16) core show channel report what outgoing SIP channel created in contextA  have native format slin16 and have no recode, but not optimized Local channels report something like: side 1  NativeFormats: (slin)    WriteFormat: slin16     ReadFormat: slin WriteTranscode: Yes (slin@16000)->(slin@8000) and for side 2  NativeFormats: (slin)    WriteFormat: slin16     ReadFormat: slin16 WriteTranscode: Yes (slin@16000)->(slin@8000)  ReadTranscode: Yes (slin@8000)->(slin@16000) also resampling looks very bad and generates a large distortion for powerful signals
Comments:	By: Asterisk Team (asteriskteam) 2016-12-03 21:46:43.804-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Vitaly K (bg1) 2016-12-03 21:49:37.143-0600 This is patch for add slin16 to capabilities for channels created from cli channel originate By: Rusty Newton (rnewton) 2016-12-05 18:03:22.240-0600 [~bg1] , we would love to have your patch contributed! However, I have removed it for a couple of reasons: * You didn't mark the patch as a contribution. * I couldn't mark the patch as a contribution because you don't have a valid license agreement and we can't accept a patch from you without one. To resolve the issue, please resubmit your license agreement submission with valid information: https://issues.asterisk.org/jira/secure/DigiumLicense.jspa By: Vitaly K (bg1) 2016-12-05 20:21:34.542-0600 I can't mark attached file as contribution  because jira report error, something like 'your license is expired'. I send empty information when request license, it is my choice -  open or not my personal information (i hope you agree). If i post patch this mean i already solve my problem with asterisk. And your choice - accept license/update/patch or delete, will you make asterisk better for your and other people or not. By: Rusty Newton (rnewton) 2016-12-06 18:09:54.587-0600 bq. I can't mark attached file as contribution because jira report error, something like 'your license is expired'. This is because you filled out the license form with invalid information. The license was incomplete and not accepted. bq. I send empty information when request license, it is my choice - open or not my personal information (i hope you agree). Choosing to fill out the form with invalid information is equivalent to choosing not to fill out the form. We cannot accept a form with invalid contact information. The purpose of having that information is due to cases where we may need to contact you for legal reasons due to licensing issues. bq. And your choice - accept license/update/patch or delete, will you make asterisk better for your and other people or not. Digium has been accepting patches from the open source community for more than a decade. I'm sure all would agree that Asterisk and the Asterisk community, including all of those companies that sell Asterisk-based products have benefited greatly from the community contributions. It is your choice to sign the agreement or not. If you do not feel that you agree with the language of the agreement then let me know and I'll open up the issue, but we definitely cannot accept your code. The submission agreement is required for all Asterisk contributors. Thanks!