ASTERISK-26676: enabling TEST_FRAMEWORK changes AST_BUILDOPT

[Home]

Summary: ASTERISK-26676: enabling TEST_FRAMEWORK changes AST_BUILDOPT_SUM

Reporter: Tzafrir Cohen (tzafrir) Labels:

Date Opened: 2016-12-23 08:16:11.000-0600 Date Closed: 2016-12-23 12:37:53.000-0600

Priority: Minor Regression? No

Status: Closed/Complete Components: Core/BuildSystem

Versions: 13.13.1 14.2.1 Frequency of
Occurrence

Related
Issues:

Environment: Attachments:

Description: AST_BUILDOPT_SUM in include/asterisk/buildopts.h is created by build_tools/make_buildopts_h . The checksum is a hash of a string that includes DEVMODE (if set) and build flags, except those explicitly ignored in the script (because they don't change the ABI).

TEST_FRAMEWORK does not seem to change the ABI and thus can be safely added to the list.

Here are all other potential build flags:

* ADDRESS_SANITIZER
* BUSYDETECT_COMPARE_TONE_AND_SILENCE
* BUSYDETECT_DEBUG
* BUSYDETECT_TONEONLY
* COMPILE_DOUBLE
* DEBUG_CHAOS
* DEBUG_FD_LEAKS
* DEBUG_THREADLOCALS
* DEBUG_THREADS
* DISABLE_INLINE
* DO_CRASH
* DONT_OPTIMIZE
* G711_NEW_ALGORITHM
* G711_REDUCED_BRANCHING
* INTEGER_CALLERID
* LEAK_SANITIZER
* LOADABLE_MODULES
* MALLOC_DEBUG
* MTX_PROFILE
* OPTIONAL_API
* STATIC_BUILD
* TEST_CODING_TABLES
* TEST_FRAMEWORK
* TEST_TANDEM_TRANSCODING
* THREAD_CRASH
* THREAD_SANITIZER
* TRACE_FRAMES
* UNDEFINED_SANITIZER
* USE_HOARD_ALLOCATOR

Comments: By: Asterisk Team (asteriskteam) 2016-12-23 08:16:13.164-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Tzafrir Cohen (tzafrir) 2016-12-23 12:37:53.308-0600

It seems I forgot to double check the information. TEST_FRAMEWORK does indeed change the ABI. Sorry for the noise.