| Summary: | ASTERISK-26747: Ambiguity in PJSIP use_avpf and force_avp | ||
| Reporter: | JoshE (n8ideas) | Labels: | |
| Date Opened: | 2017-01-24 12:35:44.000-0600 | Date Closed: | 2020-01-14 11:14:07.000-0600 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | |
| Versions: | 13.13.1 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Placeholder issue and starting a discussion for some concerns about the way that use_avpf and force_avp (undocumented, though used in pjsip) are implemented in res_pjsip in Asterisk 13+.
use_avpf right now forces the AVPF on all incoming invites. We would prefer the ability, as was closer to the behavior in chan_sip to allow it if present, but not require it. Similar to some issues with encryption, we have a need to "optimistically" accept avpf on incoming invites. Ideally, this would let us configure something like: use_avpf=yes force_avpf=no And allow an invite with RTP/AVP to pass through. Right now, this returns an invalid transport. Might be a question for @jcolp, but would a change to add this additional behavior - a knob for force_avpf - be acceptable? Secondarily, it may be beneficial to document the force_avp option, as it's currently undocumented in the .sample file. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2017-01-24 12:35:45.242-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2017-01-24 12:44:48.385-0600 Provided that behavior is backwards compatible and tests are written to cover the new behavior, it could be. As for documentation everything is documented in XML in the code which is exported onto the wiki[1]. The sample file isn't meant to serve as an exhaustive reference of options. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+13+Configuration_res_pjsip#Asterisk13Configuration_res_pjsip-endpoint_force_avp By: Rusty Newton (rnewton) 2017-01-24 16:27:21.817-0600 [~n8ideas] , you want to create a patch and push to Gerrit? By: Asterisk Team (asteriskteam) 2017-02-08 12:00:00.920-0600 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines | ||