[Home]

Summary:ASTERISK-26754: build_tools: make_build_h does not handle \ in user name
Reporter:Kirill Katsnelson (kkm)Labels:
Date Opened:2017-01-25 21:27:41.000-0600Date Closed:2017-01-31 08:33:52.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:General
Versions:13.13.1 14.2.1 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:YES, the backslash. YES, in a Linux username!  Thanks to Likewise.

$ id -un
DSAL\kkm

And this results in

#define BUILD_USER "DSAL\kkm"

which does not compile. But \b and \t are ok, so it took a \k to catch this.

Sending a patch.
Comments:By: Asterisk Team (asteriskteam) 2017-01-25 21:27:41.925-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Friendly Automation (friendly-automation) 2017-01-31 08:33:53.581-0600

Change 4823 merged by zuul:
make_build_h: handle backslashes in external strings

[https://gerrit.asterisk.org/4823|https://gerrit.asterisk.org/4823]

By: Friendly Automation (friendly-automation) 2017-01-31 08:37:21.026-0600

Change 4825 merged by Joshua Colp:
make_build_h: handle backslashes in external strings

[https://gerrit.asterisk.org/4825|https://gerrit.asterisk.org/4825]

By: Friendly Automation (friendly-automation) 2017-01-31 09:44:46.316-0600

Change 4828 merged by zuul:
make_build_h: handle backslashes in external strings

[https://gerrit.asterisk.org/4828|https://gerrit.asterisk.org/4828]