| Summary: | ASTERISK-26796: res_pjsip_transport_websocket: Via header is 'WS' when it should be 'WSS' | ||||
| Reporter: | Jørgen H (jorgen) | Labels: | |||
| Date Opened: | 2017-02-16 04:22:42.000-0600 | Date Closed: | 2017-03-01 17:54:55.000-0600 | ||
| Priority: | Major | Regression? | |||
| Status: | Closed/Complete | Components: | Resources/res_pjsip_transport_websocket | ||
| Versions: | 13.14.0 14.3.0 | Frequency of Occurrence | Constant | ||
| Related Issues: |
| ||||
| Environment: | linux x64 | Attachments: | |||
| Description: | The Via header now contains 'WS' when it should contain 'WSS'. Only the transport parameter of the URI should be 'ws'. | ||||
| Comments: | By: Asterisk Team (asteriskteam) 2017-02-16 04:22:44.504-0600 The severity of this issue has been automatically downgraded from "Blocker" to "Major". The "Blocker" severity is reserved for issues which have been determined to block the next release of Asterisk. This severity can only be set by privileged users. If this issue is deemed to block the next release it will be updated accordingly during the triage process. By: Asterisk Team (asteriskteam) 2017-02-16 04:22:45.040-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Jørgen H (jorgen) 2017-02-16 04:26:54.737-0600 Im a bit newbie on this system, but I commited a patch for this through gerrit. By: Joshua C. Colp (jcolp) 2017-02-16 05:40:19.565-0600 Per my comment on the code review this is on purpose and is not a typo. 'wss' is not valid, both insecure and secure use 'ws'. By: Joshua C. Colp (jcolp) 2017-02-16 06:03:19.485-0600 Thank you for taking the time to report this bug and helping to make Asterisk better. Unfortunately, we cannot work on this bug because your description did not include enough information. Please read over the Asterisk Issue Guidelines [1] which discusses the information necessary for your issue to be resolved and the format that information needs to be in. We would be grateful if you would then provide a more complete description of the problem. At a minimum, we need: 1. The specific steps or actions you took that caused you to encounter the problem. 2. The behavior you expected and the location of documentation that led you to that expectation. 3. The behavior you actually encountered. To demonstrate the issue in detail, please include Asterisk log files generated per the instructions on the wiki [2]. If applicable, please ensure that protocol-level trace debugging is enabled, e.g., 'sip set debug on' if the issue involves chan_sip, and configuration information such as dialplan and channel configuration. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines [2] https://wiki.asterisk.org/wiki/display/AST/Collecting+Debug+Information By: Joshua C. Colp (jcolp) 2017-02-16 06:11:50.489-0600 After further research the patch is correct and I've cleaned up the commit message and cherry picked it to the appropriate places. By: Joshua C. Colp (jcolp) 2017-02-20 14:18:36.091-0600 The original fix here was incomplete and broke the Via header. By: Richard Mudgett (rmudgett) 2017-02-21 16:51:03.789-0600 I could certainly use a debug log demonstrating the issue to verify when I reproduce the issue and when I fix it. By: Richard Mudgett (rmudgett) 2017-02-22 18:57:44.492-0600 I have updated the review on gerrit. By: Friendly Automation (friendly-automation) 2017-03-01 17:25:47.320-0600 Change 4968 merged by Joshua Colp: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS. [https://gerrit.asterisk.org/4968|https://gerrit.asterisk.org/4968] By: Friendly Automation (friendly-automation) 2017-03-01 18:21:26.717-0600 Change 4972 merged by zuul: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS. [https://gerrit.asterisk.org/4972|https://gerrit.asterisk.org/4972] By: Friendly Automation (friendly-automation) 2017-03-01 18:26:37.140-0600 Change 4973 merged by Joshua Colp: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS. [https://gerrit.asterisk.org/4973|https://gerrit.asterisk.org/4973] | ||||