[Home]

Summary:ASTERISK-02682: [patch] Add distribution lists to app_voicemail
Reporter:rtctel (rtctel)Labels:
Date Opened:2004-10-26 11:29:36Date Closed:2011-06-07 14:05:18
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) allison-sounds.tar.bz2
( 1) app_voicemail.c.cvs-2005-01-06.diff
( 2) app_voicemail.c.cvs20050131.diff
( 3) app_voicemail.c.cvs20050314.diff
( 4) app_voicemail.c.stable-1.0.3.diff
( 5) app_voicemail.c.stable-1.0.3-2.diff
( 6) _app_voicemail.c.stable-1.0.6.diff.txt
( 7) asterisk.tar.gz
Description:This patch adds support for distribution lists to app_voicemail.c

Here's the info fed to me by our code monkey, Christopher:

This is the menu tree... :\ (sorry about the format)

1.  Press six for distribution list management.
   2.  Press one to create a new distribution list.

       3.  Please enter a two digit identifier for this
distribution list.

           4.  This distribution list already exists.

       5.  Please record a name for this distribution list.

           6.  Press pound when you are finished.

       7.  Please enter each extension or two digit list identifier to add to this distribution list followed by pound.

           8.  When you are finished, press pound to finalize this list.

               13. This distribution list you specified does not exist.

           9.  Press one to confirm or press two to cancel.

               10. Distribution list successfully
created.

   11.  Press two to edit a distribution list.

       12. Please enter the two digit identifier of the
distribution list followed by pound, or press pound to hear a list.

           13. This distribution list you specified does not exist.

           14. Press one to make additions.

               7.  Please enter each extension or two digit list identifier to add to this distribution list followed by pound.

                   13. This distribution list you specified does not exist.

           15. Press two to make deletions.

               12. Please enter the two digit identifier of the distribution list followed by pound, or press pound to hear a list.

   16.  Press three to delete a distribution list.

       12. Please enter the two digit identifier of the
distribution list followed by pound, or press pound to hear a list.

           9.  Press one to confirm or press two to cancel.

   17.  Press four to send a distributed message.

       12. Please enter the two digit identifier of the
distribution list followed by pound, or press pound to hear a list.

           9.  Press one to confirm or press
two to cancel.



Summary of prompts:

1.  Press six for distribution list management.
2.  Press one to create a new distribution list.
3.  Please enter a two digit identifier for this distribution list.
4.  This distribution list already exists.
5.  Please record a name for this distribution list.
6.  Press pound when you are finished.
7.  Please enter each extension or two digit list identifier to add to
this distribution list followed by pound.
8.  When you are finished, press pound to finalize this list.
9.  Press one to confirm or press two to cancel.
10. Distribution list successfully created.
11.  Press two to edit a distribution list.
12. Please enter the two digit identifier of the distribution list
followed by pound, or press pound to hear a list.
13. This distribution list you specified does not exist.
14. Press one to make additions.
15. Press two to make deletions.
16.  Press three to delete a distribution list.
17.  Press four to send a distributed message.

Notes:

* Individual system users can create & manage
(edit, update, delete, etc) their own distribution lists.

* Users have the ability to create up to 100 lists.  It's
currently setup so that each user assigns a two digit ID to each list for quick recall and storage. This is a hard coded limited but could easily be changed.

The lists are stored in a text file with the following format:

- file=/var/spool/asterisk/vm/1234/dist/names/12.wav    (This is
the sound file of the recorded list name)
- ext=>1234 (This is just a regular extension)
- ext=>2342
- list=>12 (This is a reference to another one of the users
    saved lists)
- list=>23

* These files are currently being stored in
/var/spool/asterisk/vm/<extension>/dist/ and all recorded voice files are in /var/spool/asterisk/vm/<extension>/dist/names. --This would need to be modified to allow it to work for extensions other than default.

* As part of the distribution list creation process, the user has the option to record a name to identify the list they have created (i.e. "*" system voice identifies DL1 as "distribution list 1" unless the user records a label such as "IS Department").


****** ADDITIONAL INFORMATION ******

I'm working on getting the Disclaimer form signed.  It will come from Steve Scharf, Byron DeLoach, or Phil Erli.  The SRC fax number should be a 706-965-xxxx DID.
Comments:By: Clod Patry (junky) 2004-10-26 11:59:52

next time, you post something, please fill up correctly the CVS Date or Stable Version.
if you're not sure, then do a show version in ur CLI, and post all the output there.

By: Mark Spencer (markster) 2004-11-07 21:10:19.000-0600

Any update on the disclaimer?  I'd like to see about getting this moving ahead since it sounds like a great new feature.

By: rtctel (rtctel) 2004-11-09 10:22:31.000-0600

The disclaimer should have been submitted yesterday.  If it hasn't, please let me know ASAP.

By: rtctel (rtctel) 2004-11-09 13:59:43.000-0600

I confirmed with my supervisor that we sent the disclaimer yesterday.  I tried to reach Greg (who is apparently responsible for these) and got VM.  I left him a message with my contact #s.

By: Mark Spencer (markster) 2004-11-17 01:24:15.000-0600

Got it, no worries.  Now just time to have the code reviewed, prompts generated and get it merged in.

By: rtctel (rtctel) 2004-12-06 17:50:50.000-0600

Is someone actively working on integrating this patch?

By: zoa (zoa) 2004-12-07 06:33:41.000-0600

For those wondering what a distribution list is (i did):

It looks like its a mailing list for voice messages.
http://www.ohlone.edu/org/infosys/voicemail_user/distribution_list.html

By: brc007 (brc007) 2004-12-10 20:48:54.000-0600

Reminder sent to rtctel

Can you verify that the prompts listed in the Description are still correct? If so I'll add them to 0003006 (New batch of phrases for Allison).

--Housekeeping

By: Jeffrey C. Ollie (jcollie) 2004-12-11 22:09:45.000-0600

Can someone also update the patch?  It no longer applies cleanly to recent CVS:

patching file app_voicemail.c
Hunk #1 succeeded at 43 with fuzz 1 (offset 4 lines).
Hunk #2 succeeded at 121 (offset 12 lines).
Hunk #3 succeeded at 181 (offset 6 lines).
Hunk #4 succeeded at 278 with fuzz 1 (offset 41 lines).
Hunk ASTERISK-1 succeeded at 446 (offset 25 lines).
Hunk ASTERISK-2 succeeded at 482 (offset 41 lines).
Hunk ASTERISK-3 succeeded at 1361 with fuzz 3 (offset 718 lines).
Hunk ASTERISK-4 succeeded at 1363 (offset 20 lines).
Hunk ASTERISK-5 FAILED at 1483.
Hunk ASTERISK-6 succeeded at 3549 (offset 803 lines).
Hunk ASTERISK-7 succeeded at 3305 (offset 69 lines).
Hunk ASTERISK-8 succeeded at 4393 with fuzz 1 (offset 974 lines).
misordered hunks! output would be garbled
Hunk ASTERISK-9 FAILED at 3762.
Hunk ASTERISK-10 succeeded at 5021 (offset 975 lines).
Hunk ASTERISK-12 succeeded at 5655 (offset 1002 lines).
Hunk ASTERISK-13 succeeded at 5126 with fuzz 2 (offset 29 lines).
Hunk ASTERISK-14 succeeded at 6113 with fuzz 2 (offset 1003 lines).
Hunk ASTERISK-15 succeeded at 5439 with fuzz 2 (offset 33 lines).
Hunk ASTERISK-16 FAILED at 5494.
3 out of 20 hunks FAILED -- saving rejects to file app_voicemail.c.rej

By: twisted (twisted) 2004-12-28 10:41:33.000-0600

This bug needs responsiveness/activity to remain open - please advise/update.

--Housekeeping

By: rtctel (rtctel) 2004-12-28 21:56:06.000-0600

twisted,

See Mark's note above (11-17-04 01:24).

Is someone at digium actively working on merging this patch in?
We signed the disclaimer(s) and would _really_ like to see this patch integrated into *.

Cheers,

Mike

edited on: 12-28-04 21:57

By: twisted (twisted) 2004-12-29 08:47:31.000-0600

This is not going to happen if the patch will no longer apply to current cvs.  Please update your patch to apply to current cvs, as pointed out in the bugnotes.

By: rtctel (rtctel) 2004-12-31 11:46:31.000-0600

Our coder has agreed to make 2 shiny new patches.  One will patch cleanly against 1.0.3 and one will patch against current CVS.  He said he will work on them on Saturday night (01/01/2005) or Sunday morning (01/02/2005).

Will someone on that end (Digium) promise to review them shortly thereafter and get them into CVS?  I'd like to be able to get this off of my task list as it's the only thing 'preventing' (I wanted to wait until the patch was officially in stable) us from implementing * in-house to replace our Definity w/100 or so active ports. ;)

By: rtctel (rtctel) 2005-01-08 15:20:38.000-0600

Patch for current CVS added.

By: twisted (twisted) 2005-01-08 15:23:19.000-0600

Still waiting on prompts...   the ones in the tarball are not Allison.

By: rtctel (rtctel) 2005-01-08 18:02:49.000-0600

I will ask our programmer (in the form of this bugnote) to verify all the text for the prompts are correct and then we'll send them off to Allison on Monday (01/10/2004).

By: rtctel (rtctel) 2005-01-10 17:05:26.000-0600

There's a patch that should work for current stable (1.0.3).  Please let me know if you find any bugs.

By: rtctel (rtctel) 2005-01-10 17:07:23.000-0600

brc007,

Our programmer told me that the prompts are all correct, so if you have an upcoming batch to send to Allison, feel free to include these.  If not, let me know.  I meant to take care of this today, but didn't get around to it.

Cheers,

Mike

By: rtctel (rtctel) 2005-01-14 15:45:57.000-0600

I have uploaded the recordings Allison made for this patch as well as an updated (bugfixes) patch for stable.  I'll upload the updated CVS patch a bit later today.

/Mike

By: rtctel (rtctel) 2005-01-31 14:54:30.000-0600

I uploaded an updated patch that should apply cleanly to current CVS.

By: Olle Johansson (oej) 2005-02-13 13:01:05.000-0600

Sent mail to mailing list to get more feedback on this patch.

By: zebble (zebble) 2005-03-01 12:56:02.000-0600

Excellent feature.  It would be nice to also see an ability to keep the prepended message seperate from the original.  This allows users to re-forward messages with a new prepended message and not the original prepended message.

By: Ryan Tucker (rtucker) 2005-03-11 10:25:44.000-0600

Does anyone have a working patch against 1.0.6?  It seems to have diverted from the state-of-the-art a bit:

/usr/src/asterisk-1.0.6/apps# patch < /usr/src/app_voicemail.c.stable-1.0.3-2.diff
patching file app_voicemail.c
Hunk #2 FAILED at 177.
Hunk #4 succeeded at 3851 (offset 13 lines).
Hunk ASTERISK-1 succeeded at 4094 (offset 13 lines).
Hunk ASTERISK-2 succeeded at 4398 (offset 13 lines).
Hunk ASTERISK-3 succeeded at 5632 (offset 13 lines).
1 out of 7 hunks FAILED -- saving rejects to file app_voicemail.c.rej

Thanks!  -rt

By: Matt O'Gorman (mogorman) 2005-03-14 10:43:07.000-0600

small typo fixed

By: Matt O'Gorman (mogorman) 2005-03-16 11:19:45.000-0600

1.0.6 patch added as voicemail.diff.txt errr, i mean  app_voicemail.c.stable-1.0.6.diff.txt

edited on: 03-16-05 11:43

By: Michael Jerris (mikej) 2005-03-17 15:39:20.000-0600

please remove c++ style // comments per bug guidelines

By: Mark Spencer (markster) 2005-03-17 15:49:54.000-0600

This looks quite promising and is about ready, I think. Here are a few things which should change:

1) Remove all C++ style comments "//"...

2) in vm_dist_list_delete, use ast_say_digit_str instead of reimplementing

3) Instead of bzero(a,b), please use memset(a, 0, b).

4) Please place { at the beginning of the next line.

5) Please confirm that changes to vm_spool_dir at runtime work with this patch.

6) At the section begining 4550,9, there appears to be a change which removes the VM_SPOOOL_DIR and replaces it with the vmu->context, twice.  That appears to be an error.

7) There is already code to duplicate voicemail messages in multiple mailboxes.  Can we recycle that code to avoid further duplication in leave_distributed_voicemail.

8) Please use VM_DELETE routines to handle your deleting to be sure things happen properly.

When these are done we'll take another review pass.  Thanks!

By: Ryan Tucker (rtucker) 2005-03-21 08:32:43.000-0600

We have mogorman's patch from the 16th (for 1.0.6) in production, and all seems to be well.  I would also add voicemail context support to the things-to-add list.  Thanks!

By: nick (nick) 2005-04-10 16:08:03

rctel, have you made the changes Mark asked for?

-Housekeeping

By: Michael Jerris (mikej) 2005-04-18 12:14:24

Reminder sent to rtctel

Do you have a status update on this?

By: rtctel (rtctel) 2005-04-18 12:19:13

Nick/MikeJ,

Christopher is out of the office this week.  I asked him about it earlier (last week?) and he said that he would take care of the changes Mark requested.

Cheers,

Mike

By: Michael Jerris (mikej) 2005-05-23 22:41:40

It's been over a month so lets bring this one back up.  We need updated patches including mark's requested changes.  What files on this bug can be deleted?

By: Clod Patry (junky) 2005-06-20 18:52:11

rtctel: any development from Christopher here?

This is the last chance, it makes like 2 months of inactivity.

/Housekeeping



By: Michael Jerris (mikej) 2005-06-27 22:31:47

Closed due to no response.  If anyone would like to take this on, or would like to persue getting this in, please re-open with requested updates.