Summary:	ASTERISK-26893: No "alert" or "progress" in chan_ooh323 if debug is enabled only on the module
Reporter:	Marco Giordani (marco_g)	Labels:
Date Opened:	2017-03-23 03:53:14	Date Closed:	2018-04-25 10:22:31
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Addons/chan_ooh323
Versions:	13.14.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Debian 8 amd64	Attachments:
Description:	During my debug of an h323 call from another vendor device I noticed that asterisk doesn’t send back “alerting” to the caller party and the call never starts “ringing” for the caller. This happens only if debug is enabled from the cli with “ooh323 set debug” and core debug is off. When both ooh323 debug and core debug are consistent (enabled or disabled) the call behavior is normal and asterisk sends back the alerting message. Even if I should not make assumption, I’ve noticed that if h323 debug is enabled, ooManualRingback is invoked by ast_debug that executes only if core debug is enabled. The same problem is present for ooManualProgress. I have made a very  simple patch that solves the problem invoking ooManualRingback and ooManualProgress before ast_debug.
Comments:	By: Asterisk Team (asteriskteam) 2017-03-23 03:53:19.297-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Alexander Anikin (may213) 2017-03-23 16:57:58.484-0500 Hi Marco, I will test that issue on my environment. Haven't see this before and could be affect only debian. By: Alexander Anikin (may213) 2017-03-23 17:15:09.538-0500 The issue found really, incorrect use function call as args for ast_debug/ast_verb. If there are no such level of verbose/debug ast_log don't call with args. I will check all codes of chan_ooh323 for this issue and produce patch. By: Friendly Automation (friendly-automation) 2018-04-25 10:22:32.956-0500 Change 8850 merged by Jenkins2: chan_ooh323: fix ooManualProgress/ooManualRingback on ooh323 debuggin on [https://gerrit.asterisk.org/8850|https://gerrit.asterisk.org/8850] By: Friendly Automation (friendly-automation) 2018-04-25 10:42:01.738-0500 Change 8849 merged by Jenkins2: chan_ooh323: fix ooManualProgress/ooManualRingback on ooh323 debuggin on [https://gerrit.asterisk.org/8849|https://gerrit.asterisk.org/8849] By: Friendly Automation (friendly-automation) 2018-04-25 10:47:54.259-0500 Change 8848 merged by Richard Mudgett: chan_ooh323: fix ooManualProgress/ooManualRingback on ooh323 debuggin on [https://gerrit.asterisk.org/8848|https://gerrit.asterisk.org/8848]