[Home]

Summary:ASTERISK-26913: Music on hold restart when second user comes
Reporter:Adagio (studioadagio)Labels:
Date Opened:2017-03-31 03:34:36Date Closed:2020-01-11 07:53:45.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_confbridge Resources/res_musiconhold
Versions:13.14.0 Frequency of
Occurrence		Occasional
Related
Issues:
Environment:Attachments:
Description:The first user who join the confbridge have a user profile with
music_on_hold_when_empty=yes
music_on_hold_class=Taxinergy_taxis_easy

music on hold start well
but sometime when the second user join confbridge, music on hold restart and cover all voices
In attached file confbridge_record.mp3 : at 30 seconds, you can listen to the restart of the sound

/MOH directory listing
.
├── Customer_01
│   └── moh.sln
├── Customer_02
│   └── moh.sln
├── Customer_03
│   └── moh.sln
├── Customer_04
│   └── moh.sln
├── convert.sh
├── Customer_05
│   └── moh.sln
├── Customer_06
│   └── moh.sln
└── Customer_07
   └── moh.sln
Comments:By: Asterisk Team (asteriskteam) 2017-03-31 03:34:39.170-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Rusty Newton (rnewton) 2017-03-31 15:27:42.924-0500

Thanks for all the debug. Can you also include a basic extension.conf or dialplan with which you reproduce the issue?
By: Adagio (studioadagio) 2017-04-06 09:49:20.197-0500

Hi Asterisk team
Our dialplan is really basic, it looks like :
exten => XXXXXXXXXX,1,agi(AGI_SCRIPT_1)
exten => YYYYYYYYYYY,1,agi(AGI_SCRIPT_2)
exten => ZZZZZZZZZZZ,1,agi(AGI_SCRIPT_3)

All the logic is in the script !

But now I think we fixed the issue, no more bug since we did this :
In apps/app_confbridge.c file, we dupplicated call to function conf_moh_stop function that is in conf_handle_second_active function
Here is the result :
{noformat}
void conf_handle_second_active(struct confbridge_conference *conference)
{
       /* If we are the second participant we may need to stop music on hold on the first */
       struct confbridge_user *first_user = AST_LIST_FIRST(&conference->active_list);

       if (ast_test_flag(&first_user->u_profile, USER_OPT_MUSICONHOLD)) {
               conf_moh_stop(first_user);
               conf_moh_stop(first_user);
       }
       conf_update_user_mute(first_user);
}
{noformat}

Best regards
By: Rusty Newton (rnewton) 2017-04-06 17:07:28.254-0500

Oh! Nice, do you want to submit a patch, push it onto Gerrit and get it into Asterisk?

[1] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process
[2] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage


By: Asterisk Team (asteriskteam) 2017-04-21 12:00:01.118-0500

Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1].

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines