ASTERISK-27022: res_rtp_asterisk: Incorrect SSRC change for RTCP component

[Home]

Summary: ASTERISK-27022: res_rtp_asterisk: Incorrect SSRC change for RTCP component

Reporter: Michael Walton (mike@farsouthnet.com) Labels:

Date Opened: 2017-05-28 22:32:24 Date Closed: 2017-06-15 13:53:38

Priority: Minor Regression?

Status: Closed/Complete Components: Resources/res_rtp_asterisk

Versions: 13.16.0 14.4.0 Frequency of
Occurrence Constant

Related
Issues:

Environment: N/A Attachments:

Description: Found by code inspection in function ast_rtp_change_source(). The following code snippet refers:
{code:title=res_rtp_asterisk.c|borderStyle=solid}
if (srtp) {
ast_debug(3, "Changing ssrc for SRTP from %u to %u\n", rtp->ssrc, ssrc);
res_srtp->change_source(srtp, rtp->ssrc, ssrc);
if (rtcp_srtp != srtp) {
res_srtp->change_source(srtp, rtp->ssrc, ssrc);
}
}
{code}
The third last line should I think be:
{code:title=res_rtp_asterisk.c|borderStyle=solid}
res_srtp->change_source(rtcp_srtp, rtp->ssrc, ssrc);
{code}

Comments: By: Asterisk Team (asteriskteam) 2017-05-28 22:32:25.587-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].