Summary:	ASTERISK-27043: Core/BuildSystem: Add defines to fix build with LibreSSL
Reporter:	Guido Falsi (madpilot)	Labels:
Date Opened:	2017-06-08 10:51:58	Date Closed:	2017-06-15 13:54:47
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	13.16.0 14.5.0 GIT	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	Asterisk fails to build with recent LibreSSL. I'm creating a git review including patches I got from the OpenBSD project which address this issue.
Comments:	By: Asterisk Team (asteriskteam) 2017-06-08 10:51:58.832-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Guido Falsi (madpilot) 2017-06-08 11:00:48.873-0500 I failed to cherry pick the patch to branch 14. I don't see any significant differences in the 14 and master branches. What is the correct procedure to solve conflicts when unable to cherry-pick directly? Thanks. By: Richard Mudgett (rmudgett) 2017-06-08 11:18:08.445-0500 You will have to cherry-pick your patch to a branch based off of the 14 branch locally on your machine.  You likely will have to resolve conflicts since that would be why the cherry-pick button on the gerrit web page failed.  Once you have resolved the conflicts you can then post the patch to gerrit on the 14 branch. https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Guido Falsi (madpilot) 2017-06-08 15:32:36.595-0500 Thanks for the instructions. I created the code review for 14 branch. he source code in master was modified substantially and I don't have a patch ready for it. At present I'm unable to test with master, but if there is interest I can do that in the near future. By: Richard Mudgett (rmudgett) 2017-06-08 15:52:08.979-0500 The 15 branch is expected to be created near the end of July so it would be needed by then at the latest.  I'm not the final arbiter, but it seems reasonable to prevent the master patch from falling through the cracks, the 13 and 14 patches may be held up waiting for the master branch patch. By: Guido Falsi (madpilot) 2017-06-09 08:39:17.214-0500 I also applied changes to master. I'm waiting for review. Thanks for your replies!