[Home]

Summary:ASTERISK-27084: Reduce verbosity while loading PBX extensions.
Reporter:Ludovic Gasc (Eyepea) (gmludo)Labels:patch
Date Opened:2017-06-23 16:04:47Date Closed:2018-01-22 09:40:38.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:PBX/pbx_config
Versions:13.16.0 15.2.0 Frequency of
Occurrence
Related
Issues:
Environment:Debian 8Attachments:( 0) extensions_adding_log_level.patch
Description:In the actual version of Asterisk, you need a log level of 3 to track a call via logs.

But at the same time, each time you reload the dialplan, you have a lot of messages like that are present because it's also at level 3:

Added extension 'XXXXX' priority 1 to YYYYYYYYYYY

It isn't useful logs for us.

This patch enables to customize the log level via the configuration file.

Thanks for your feedback.

Ps: If you plan to simply change the priority level of this log, it's also good to us: At least for us, these logs are less critical that runtime calls.
Comments:By: Asterisk Team (asteriskteam) 2017-06-23 16:04:48.398-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Rusty Newton (rnewton) 2017-06-26 16:11:56.692-0500

I've never heard this complaint before, and it is such a one-off thing that many people may not like adding another option just for the preference of possibly a few people.

It is always better if we can avoid adding further options I think, to minimize the inflation of configuration over time.

Would you like to create a patch instead to push the priority of the log message lower , to say level 4 or 5?

I could be wrong, but I think the community and core developers may find that a better solution.

If you agree, then go ahead and create the new patch and submit it to Gerrit. If others have a problem with it then you'll find out there.

Thanks!

By: Ludovic Gasc (Eyepea) (gmludo) 2017-06-27 04:58:35.812-0500

> I've never heard this complaint before,

It's "normal": Contrary several users, we use asterisk dialplan as storage for some data that don't change often: We generate some parts on the fly because Asterisk is very efficient to re-read dialplan and it enables us to increase the number of devices by Asterisk.

However, the "drawback", it's necessary to reload to apply new configuration, it's that that generates too much logs.
We know also it seems possible to update dialplan on the fly, but not yet tested.

> It is always better if we can avoid adding further options I think, to minimize the inflation of configuration over time.

I'm agree with you.

> Would you like to create a patch instead to push the priority of the log message lower , to say level 4 or 5?

If it's ok for you to increase the log level of these messages, it's clearly an option we prefer.

> If you agree, then go ahead and create the new patch and submit it to Gerrit. If others have a problem with it then you'll find out there.

Ok, we will do that.

By: Rusty Newton (rnewton) 2017-06-27 13:14:18.955-0500

Thanks Ludovic. Remember to reference this issue number in your Gerrit submission and it will be linked automatically to this issue.

By: Ludovic Gasc (Eyepea) (gmludo) 2018-01-11 08:50:30.290-0600

My co-worker has pushed the patch in Gerrit and adapted for Asterisk 15.

Do you have enough information from our side ?

Thanks for the reviewing.

By: Kevin Harwell (kharwell) 2018-01-11 09:14:03.005-0600

{quote}Do you have enough information from our side ?{quote}
Yes, and thanks for submitting a patch.


By: BenoƮt Dereck-Tricot (krells) 2018-01-12 00:25:25.702-0600

When I left Ludovic yesterday, he understood Joshua's reaction in Gerrit and told me to suggest a change in master only.
I told him that I will, and at the same time, I'll provide an adapted patch which adds an option in the config file.

I simplified the option, which is now boolean, much easier to understand and, of course, defaulting to the previous behavior.

He should have been right, because Joshua Colp came to the same idea, but as I already did it anyway, I just submitted it.

Feel free to ignore it or use it in master.


By: Friendly Automation (friendly-automation) 2018-01-22 09:40:39.085-0600

Change 7982 merged by Jenkins2:
pbx: Reduce verbosity while loading extensions

[https://gerrit.asterisk.org/7982|https://gerrit.asterisk.org/7982]

By: Friendly Automation (friendly-automation) 2018-01-22 09:44:07.107-0600

Change 7981 merged by Jenkins2:
pbx: Reduce verbosity while loading extensions

[https://gerrit.asterisk.org/7981|https://gerrit.asterisk.org/7981]

By: Friendly Automation (friendly-automation) 2018-01-22 09:45:00.594-0600

Change 7896 merged by Joshua Colp:
pbx: Reduce verbosity while loading extensions

[https://gerrit.asterisk.org/7896|https://gerrit.asterisk.org/7896]

By: Corey Farrell (coreyfarrell) 2018-01-22 12:21:12.359-0600

I've updated the title of this ticket to make the release notes more accurate.