Summary:	ASTERISK-27093: ODBC deadlocks when app_directory tries to play back non-existent voicemail greeting
Reporter:	James Terhune (bigjimmy)	Labels:
Date Opened:	2017-06-29 10:20:07	Date Closed:	2017-07-10 13:22:22
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Applications/app_directory Applications/app_voicemail/ODBC
Versions:	13.16.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Ubuntu 16.04, ODBC using mysql as a backend	Attachments:	( 0) 0001-app_voicemail-Cleanup-ODBC-connection-handling.patch ( 1) patch_vm_directory_release
Description:	If we use app_directory and the directory structure for the context doesn't exist, the ODBC connection will stay locked and the channel cannot be destroyed. We see the following in the log: {noformat} [2017-06-28 14:45:28] WARNING[17794][C-0000002f]: app_voicemail.c:3886 retrieve_file: Failed to open/create '/var/spool/asterisk/voicemail/directory1/433/greet.txt' {noformat} It appears that this is caused by a missing ast_odbc_release_obj(). Adding it  appears to fix the issue.
Comments:	By: Asterisk Team (asteriskteam) 2017-06-29 10:20:08.019-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: James Terhune (bigjimmy) 2017-06-29 10:20:50.913-0500 This patch appears to fix the issue. By: Sean Bright (seanbright) 2017-06-29 14:19:31.104-0500 [~bigjimmy], can you give the patch I attached a try and let me know if you run into any problems? It cleans up all of the ODBC related functions. By: James Terhune (bigjimmy) 2017-06-30 08:19:37.245-0500 @seanbright, this patch fixes the issue. I also ran some other tests on it and I didn't run into any problems.