Asterisk
  1. Asterisk
  2. ASTERISK-27152

Sending a "tel" uri in a From or To header in an unauthenticated message causes asterisk to crash

    Details

      Description

      Easily reproducable. Send any message to asterisk with "From: tel:+1000" in the headers.

      The crash is in pjsip_message_ip_updater.c:sanitize_tdata. When we respond with even a 401, that function is called but it assumes that the From, To, and Contact uris are sip uris and casts the header's URI to pjsip_sip_uri *uri. It then tries to call pjsip_param_find on uri->other_param. Since the uri is actually a tel uri and other_param isn't at the same offset in pjsip_sip_uri as it is in pjsip_tel_uri, we get a crash.

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          Asterisk Team added a comment -

          Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

          A good first step is for you to review the Asterisk Issue Guidelines if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

          Then, if you are submitting a patch, please review the Patch Contribution Process.

          Show
          Asterisk Team added a comment - Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the Asterisk Issue Guidelines if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the Patch Contribution Process .
          Hide
          Friendly Automation added a comment -

          Change 6350 merged by Joshua Colp:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6350

          Show
          Friendly Automation added a comment - Change 6350 merged by Joshua Colp: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6350
          Hide
          Friendly Automation added a comment -

          Change 6360 merged by Joshua Colp:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6360

          Show
          Friendly Automation added a comment - Change 6360 merged by Joshua Colp: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6360
          Hide
          Friendly Automation added a comment -

          Change 6349 merged by Jenkins2:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6349

          Show
          Friendly Automation added a comment - Change 6349 merged by Jenkins2: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6349
          Hide
          Friendly Automation added a comment -

          Change 6355 merged by Joshua Colp:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6355

          Show
          Friendly Automation added a comment - Change 6355 merged by Joshua Colp: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6355
          Hide
          Friendly Automation added a comment -

          Change 6351 merged by Joshua Colp:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6351

          Show
          Friendly Automation added a comment - Change 6351 merged by Joshua Colp: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6351
          Hide
          Friendly Automation added a comment -

          Change 6363 merged by Joshua Colp:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6363

          Show
          Friendly Automation added a comment - Change 6363 merged by Joshua Colp: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6363
          Hide
          Friendly Automation added a comment -

          Change 6352 merged by Jenkins2:
          pjsip_message_ip_updater: Fix issue handling "tel" URIs

          https://gerrit.asterisk.org/6352

          Show
          Friendly Automation added a comment - Change 6352 merged by Jenkins2: pjsip_message_ip_updater: Fix issue handling "tel" URIs https://gerrit.asterisk.org/6352

            People

            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: