| Summary: | ASTERISK-27164: [patch] Add IPv6 Support for DUNDi | ||||
| Reporter: | Adam Secombe (asecombe) | Labels: | patch | ||
| Date Opened: | 2017-07-30 18:28:42 | Date Closed: | 2018-08-27 09:38:49 | ||
| Priority: | Minor | Regression? | |||
| Status: | Closed/Complete | Components: | PBX/pbx_dundi | ||
| Versions: | 13.9.1 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Fedora 25 | Attachments: | ( 0) dundi.patch | ||
| Description: | The attached patch has been tested for the last few months against 13.9.1, no issues have been found.
This ticket was previously raised and closed out with the request of a patch to be created: ASTERISK-26950 | ||||
| Comments: | By: Asterisk Team (asteriskteam) 2017-07-30 18:28:43.453-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Adam Secombe (asecombe) 2017-07-30 18:30:15.147-0500 Attached patch to add IPv6 support to DUNDi By: Rusty Newton (rnewton) 2017-08-01 09:26:56.640-0500 [~asecombe], thanks for the report and contribution. Feel free to move on with the next step which is to push your patch onto Gerrit for the review process: https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Kirsty Tyerman (ktyerman) 2017-08-06 22:17:43.934-0500 This has been done. See here: https://gerrit.asterisk.org/#/c/6173/ By: Adam Secombe (asecombe) 2017-11-28 23:39:56.416-0600 Added the following update against the patch - https://gerrit.asterisk.org/#/c/6173/ - the patch was initially rejected due to not adopting the netsock2 library. This approach was looked at and it was considered to be a much more obtrusive change than just adding the IPv6 support - could the patch please be reconsidered as is, as the patch has been now in production for 6+ months without any issues. It adds quite a useful function to the asterisk baseline and as IPv6 becomes more and more commonly sought after, I am sure other end users will also be seeking this function. By: Kirsty Tyerman (ktyerman) 2018-06-11 19:02:52.231-0500 Have updated the patch to move to the netsock2 library. Have applied patch to Asterisk-14, Asterisk-15 and master. Have abandoned patch to Asterisk-13. Asterisk-14: https://gerrit.asterisk.org/#/c/9150/ Asterisk-15: https://gerrit.asterisk.org/#/c/9174/ Master: https://gerrit.asterisk.org/#/c/9175/ By: Friendly Automation (friendly-automation) 2018-08-27 09:38:50.244-0500 Change 9175 merged by Jenkins2: pbx_dundi: Added IPv6 support for dundi [https://gerrit.asterisk.org/9175|https://gerrit.asterisk.org/9175] By: Friendly Automation (friendly-automation) 2018-08-27 09:59:36.963-0500 Change 9953 merged by Joshua Colp: pbx_dundi: Added IPv6 support for dundi [https://gerrit.asterisk.org/9953|https://gerrit.asterisk.org/9953] By: Friendly Automation (friendly-automation) 2018-08-27 09:59:53.855-0500 Change 9954 merged by Joshua Colp: pbx_dundi: Added IPv6 support for dundi [https://gerrit.asterisk.org/9954|https://gerrit.asterisk.org/9954] | ||||