[Home]

Summary:ASTERISK-27177: ooh323c: misleading indentation in addons/ooh323c/src/ooSocket.c
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2017-08-03 23:13:25Date Closed:2017-09-05 06:42:03
Priority:MinorRegression?
Status:Closed/CompleteComponents:
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:At line 387 (note the extra ';' at the first line):

{code}
     if ((host = ast_sockaddr_stringify_addr(&addr)) != NULL);
       strncpy(destAddr, host, strlen(host));
{code}

Credit: warning from gcc.
Comments:By: Asterisk Team (asteriskteam) 2017-08-03 23:13:26.046-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Rusty Newton (rnewton) 2017-08-07 16:22:58.214-0500

Assigning to Alexander.

By: Friendly Automation (friendly-automation) 2017-09-05 06:42:05.411-0500

Change 6376 merged by Jenkins2:
chan_ooh323: Fix confusing indentation warning

[https://gerrit.asterisk.org/6376|https://gerrit.asterisk.org/6376]

By: Friendly Automation (friendly-automation) 2017-09-05 07:03:47.048-0500

Change 6377 merged by Jenkins2:
chan_ooh323: Fix confusing indentation warning

[https://gerrit.asterisk.org/6377|https://gerrit.asterisk.org/6377]

By: Friendly Automation (friendly-automation) 2017-09-05 07:03:51.918-0500

Change 6378 merged by Jenkins2:
chan_ooh323: Fix confusing indentation warning

[https://gerrit.asterisk.org/6378|https://gerrit.asterisk.org/6378]

By: Friendly Automation (friendly-automation) 2017-09-05 07:18:48.581-0500

Change 6379 merged by Joshua Colp:
chan_ooh323: Fix confusing indentation warning

[https://gerrit.asterisk.org/6379|https://gerrit.asterisk.org/6379]