Summary:	ASTERISK-27255: alembic: Add support for Microsoft SQL server
Reporter:	Florian Floimair (f.floimair)	Labels:
Date Opened:	2017-09-06 05:22:26	Date Closed:	2017-09-11 06:41:38
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Contrib/General
Versions:	14.6.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	The alembic scripts included with Asterisk are currently not working with MS-SQL. This is mainly due to the fact, that MS-SQL has no native Enum-type and therefore needs to work with constraints as mentioned here: http://bit.ly/2x9r8pb. The referenced gerrit change request enhances the alembic environment and the migration scripts so that they work with MS-SQL as well. Successfully tested migrations with alembic 0.8.8, sqlalchemy 1.0.15 and MS-SQL server 13.1 (on Microsoft Azure) both online and offline (with the --sql switch) as well as checked for any regressions by also using MySQL 5.7.
Comments:	By: Asterisk Team (asteriskteam) 2017-09-06 05:22:27.471-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Kevin Harwell (kharwell) 2017-09-08 10:54:17.867-0500 There was some concern about this going into the code base, and what that means moving forward from a maintenance perspective. After some discussion it was decided that modifying the Asterisk alembic scripts in order to allow MS-SQL Server support would be acceptable. However, with the following caveat: {panel} MS-SQL Server support in Asterisk is not officially supported and should be treated as-is. Future changes/additions to any alembic scripts may break things for MS-SQL Server. {panel} That being said, as changes are made to the alembic scripts effort should and will be made to try and not break things, but it's just not guaranteed. Also, patches of course will be accepted from anyone with an interest in keeping the MS-SQL support current. By: Friendly Automation (friendly-automation) 2017-09-11 06:41:39.688-0500 Change 6459 merged by Jenkins2: alembic: Add support for MS-SQL [https://gerrit.asterisk.org/6459|https://gerrit.asterisk.org/6459] By: Friendly Automation (friendly-automation) 2017-09-11 06:49:57.938-0500 Change 6448 merged by Jenkins2: alembic: Add support for MS-SQL [https://gerrit.asterisk.org/6448|https://gerrit.asterisk.org/6448] By: Friendly Automation (friendly-automation) 2017-09-11 06:57:00.741-0500 Change 6424 merged by Jenkins2: alembic: Add support for MS-SQL [https://gerrit.asterisk.org/6424|https://gerrit.asterisk.org/6424] By: Friendly Automation (friendly-automation) 2017-09-11 06:57:22.345-0500 Change 6449 merged by Jenkins2: alembic: Add support for MS-SQL [https://gerrit.asterisk.org/6449|https://gerrit.asterisk.org/6449]