Summary: | ASTERISK-27365: [patch] chan_sip: Crypto attribute not last but first on SDP media level. | ||
Reporter: | Alexander Traud (traud) | Labels: | patch pjsip |
Date Opened: | 2017-10-21 03:36:59 | Date Closed: | 2017-10-24 08:51:31 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability Channels/chan_sip/SRTP |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) sdp_media_level_required_at_begin.patch | |
Description: | Some VoIP/SIP implementations have a limit of 32 attributes on the media level in SDP. You hit this limitation, if you allow a lot of audio codecs. Without Compact Headers enabled (see ASTERISK-26932), each audio codec creates a rtpmap attribute. Some codecs even create a fmtp attribute. If you have more than 32, affected devices like the desktop phone Gigaset DE900 IP Pro (firmware [02.01.00|https://teamwork.gigaset.com/gigawiki/pages/viewpage.action?pageId=372408431]) ignore all further attributes on that specific media level. If a sRTP a:crypto= is sent as last attribute, the Gigaset is not aware of the crypto and establishes a non-encrypted call.
In the channel driver {{chan_sip}}, any crypto attribute is sent last. In {{chan_pjsip}} those attributes are send first. The attached patch changes {{chan_sip}} to match {{chan_pjsip}}. | ||
Comments: | By: Friendly Automation (friendly-automation) 2017-10-24 08:51:32.600-0500 Change 6860 merged by Jenkins2: chan_sip: Crypto attribute not last but first on SDP media level. [https://gerrit.asterisk.org/6860|https://gerrit.asterisk.org/6860] By: Friendly Automation (friendly-automation) 2017-10-24 09:28:58.923-0500 Change 6859 merged by Joshua Colp: chan_sip: Crypto attribute not last but first on SDP media level. [https://gerrit.asterisk.org/6859|https://gerrit.asterisk.org/6859] By: Friendly Automation (friendly-automation) 2017-10-24 09:29:20.471-0500 Change 6858 merged by Joshua Colp: chan_sip: Crypto attribute not last but first on SDP media level. [https://gerrit.asterisk.org/6858|https://gerrit.asterisk.org/6858] |