| Summary: | ASTERISK-27435: [patch] configure: pjsip_evsub_set_uas_timeout not found. | ||
| Reporter: | Alexander Traud (traud) | Labels: | patch pjsip |
| Date Opened: | 2017-11-20 09:54:05.000-0600 | Date Closed: | 2017-11-21 09:54:48.000-0600 |
| Priority: | Trivial | Regression? | |
| Status: | Closed/Complete | Components: | Core/BuildSystem |
| Versions: | 13.8.2 15.1.2 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) build_system.patch | |
| Description: | {quote}An earlier approach was to add support for setting pjproject's timer (via a pjproject patch) and while that patch is still included here, we don't use that call at the moment.{quote}
Version controlled source code should not contain dead code, because if the code must be found again, it is still within the versioning system. Furthermore, that code broke, because Teluu, the maintainers of PJSIP, [flipped|http://trac.pjsip.org/repos/changeset/5558] the name of that function from pjsip_evsub_*uas_set*\_timeout to pjsip_evsub_*set_uas*\_timeout, while they included the proposed patch. Because of this, _configure_ is not able to find that symbol in PJSIP 2.7. Because of this, the user might get confused what is wrong with his PJSIP, especially if he is using not the bundled but an external one. The attached patch avoids to look for that unused symbol. | ||
| Comments: | By: Friendly Automation (friendly-automation) 2017-11-21 09:54:49.158-0600 Change 7304 merged by Joshua Colp: BuildSystem: pjsip_evsub_set_uas_timeout was not used. [https://gerrit.asterisk.org/7304|https://gerrit.asterisk.org/7304] By: Friendly Automation (friendly-automation) 2017-11-21 10:18:45.401-0600 Change 7305 merged by Joshua Colp: BuildSystem: pjsip_evsub_set_uas_timeout was not used. [https://gerrit.asterisk.org/7305|https://gerrit.asterisk.org/7305] By: Friendly Automation (friendly-automation) 2017-11-21 10:34:23.124-0600 Change 7303 merged by Joshua Colp: BuildSystem: pjsip_evsub_set_uas_timeout was not used. [https://gerrit.asterisk.org/7303|https://gerrit.asterisk.org/7303] By: Friendly Automation (friendly-automation) 2018-03-29 15:03:21.476-0500 Change 8633 merged by Jenkins2: BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2). [https://gerrit.asterisk.org/8633|https://gerrit.asterisk.org/8633] By: Friendly Automation (friendly-automation) 2018-03-29 15:04:02.157-0500 Change 8631 merged by Jenkins2: BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2). [https://gerrit.asterisk.org/8631|https://gerrit.asterisk.org/8631] By: Friendly Automation (friendly-automation) 2018-03-29 15:21:46.444-0500 Change 8632 merged by Kevin Harwell: BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2). [https://gerrit.asterisk.org/8632|https://gerrit.asterisk.org/8632] | ||