Summary:	ASTERISK-27561: Store CallerID name for the ENTERQUEUE queue log event
Reporter:	Leandro Dardini (ldardini)	Labels:	patch
Date Opened:	2018-01-07 05:22:27.000-0600	Date Closed:	2020-01-14 11:14:02.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:	13.19.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue.c.diff
Description:	This is a very small improvement about the queue log subsystem, adding the callerid name in the data4 field in the queue log for ENTERQUEUE parameter.
Comments:	By: Asterisk Team (asteriskteam) 2018-01-07 05:22:28.383-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Kevin Harwell (kharwell) 2018-01-09 17:15:48.958-0600 Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines [2] * Review the Code Review Checklist [3] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4] * As this is a new feature, please read the New Feature Guidelines [5] * Make sure your new feature applies cleanly to Asterisk trunk When ready, submit your patch and any tests to Gerrit [6] for code review. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines [3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist [4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation [5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines [6] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Kevin Harwell (kharwell) 2018-01-09 17:18:59.070-0600 At this time I'm not really sure if adding new fields on existing queue log events is allowed in currently released branches of Asterisk as there might be the potential of breaking user parsers. That being said if you do push this patch up to gerrit it might be advantageous to do it first against master, and then get people's opinion on whether or not it could/should be cherry-picked to other branches. By: Kevin Harwell (kharwell) 2018-01-09 17:20:47.202-0600 Also, when this patch does go in the following wiki page should also be updated to reflect the new fields value for the event: https://wiki.asterisk.org/wiki/display/AST/Queue+Logs By: Kevin Harwell (kharwell) 2018-01-09 17:26:39.908-0600 [~ldardini], Is submitting the patch on gerrit something you think you will be able to get to? By: Asterisk Team (asteriskteam) 2018-01-24 12:00:01.198-0600 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines