Summary:	ASTERISK-27563: pjsip modules always get -O2 even when DONT_OPTIMIZE is set
Reporter:	George Joseph (gjoseph)	Labels:	pjsip
Date Opened:	2018-01-08 07:45:43.000-0600	Date Closed:	2018-07-17 12:16:07
Priority:	Major	Regression?	Yes
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	13.18.5 GIT 15.1.5	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	gcc -o res_pjsip_transport_management.o -c res_pjsip_transport_management.c -MD -MT res_pjsip_transport_management.o -MF .res_pjsip_transport_management.o.d -MP -pthread -I/usr/src/asterisk/asterisk/include    -I/usr/include/libxml2  -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations   -g3  -O0  -march=native -fPIC -DAST_MODULE=\"res_pjsip_transport_management\"  -DPJ_AUTOCONF=1 -O2 -DPJ_IS_BIG_ENDIAN=0  -DPJ_IS_LITTLE_ENDIAN=1 -I/usr/src/asterisk/asterisk/third-party/pjproject/source/pjlib/include -I/usr/src/asterisk/asterisk/third-party/pjproject/source/pjlib-util/include -I/usr/src/asterisk/asterisk/third-party/pjproject/source/pjnath/include -I/usr/src/asterisk/asterisk/third-party/pjproject/source/pjmedia/include -I/usr/src/asterisk/asterisk/third-party/pjproject/source/pjsip/include   notice that pjsip modules get -O2 because it's in the PJPROJECT_CFLAGS variable even though DONT_OPTIMIZE is set.
Comments:	By: George Joseph (gjoseph) 2018-01-08 13:55:14.562-0600 I NEVER use --enable-coverage By: Corey Farrell (coreyfarrell) 2018-01-08 15:00:44.424-0600 pjproject configure script determines if the {{-O}} flag should be used for building pjproject.  Unfortunately flag is exposed to to build.mak and libpjproject.pc, so bundled or not we get the {{-O2}} chosen by pjproject configure script. I think this has to be fixed in pjproject.  libpjproject.pc should not contain {{-g}} or {{-O}} options (this would fix non-bundled builds).  It may also require some tweaks to the pjproject {{build.mak.in}} or we might just need to adjust which variables we use to extract the CFLAGS needed to use bundled pjproject. By: Friendly Automation (friendly-automation) 2018-07-17 12:16:09.618-0500 Change 9459 merged by Joshua Colp: Build: Fix modules getting their optimization setting overridden. [https://gerrit.asterisk.org/9459|https://gerrit.asterisk.org/9459] By: Friendly Automation (friendly-automation) 2018-07-17 12:16:53.725-0500 Change 9461 merged by Joshua Colp: Build: Fix modules getting their optimization setting overridden. [https://gerrit.asterisk.org/9461|https://gerrit.asterisk.org/9461] By: Friendly Automation (friendly-automation) 2018-07-17 12:17:14.717-0500 Change 9460 merged by Joshua Colp: Build: Fix modules getting their optimization setting overridden. [https://gerrit.asterisk.org/9460|https://gerrit.asterisk.org/9460] By: Friendly Automation (friendly-automation) 2018-07-18 09:13:35.863-0500 Change 9462 merged by George Joseph: Build: Fix modules getting their optimization setting overridden. [https://gerrit.asterisk.org/9462|https://gerrit.asterisk.org/9462]