Summary:	ASTERISK-27569: Not answering call on Polarity reversal Event
Reporter:	Pushkar Singh (pushkar.singh)	Labels:
Date Opened:	2018-01-10 07:27:15.000-0600	Date Closed:
Priority:	Minor	Regression?
Status:	Open/New	Components:	Channels/chan_dahdi
Versions:	15.1.5	Frequency of Occurrence	Constant
Related Issues:
Environment:	Linux	Attachments:
Description:	It seems that even though after detecting polarity reversal on asterisk, Asterisk does not answer the call. On further debugging on the issue it seems that, if "answeronpolarityswitch" is set to "yes" and "callprogress" is set to "no" as soon as call is answered and polarity reversal is detected by asterisk, Asterisk change the call state to UP but actually doesnot sending CONTORL_ANSWER frame to core. Below is the code snippet in order to support the above statement: 8122                         if (p->answeronpolarityswitch && 8123                                 ((ast_channel_state(ast) == AST_STATE_DIALING) || 8124                                 (ast_channel_state(ast) == AST_STATE_RINGING))) { 8125                                 ast_debug(1, "Answering on polarity switch!\n"); 8126                                 ast_setstate(p->owner, AST_STATE_UP); 8127                                 if (p->hanguponpolarityswitch) {
Comments:	By: Asterisk Team (asteriskteam) 2018-01-10 07:27:16.811-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Asterisk Team (asteriskteam) 2018-01-10 07:27:17.944-0600 We appreciate the difficulties you are facing, however information request type issues would be better served in a different forum. The Asterisk community provides support over IRC, mailing lists, and forums as described at http://asterisk.org/community. The Asterisk issue tracker is used specifically to track issues concerning bugs and documentation errors. If this issue is actually a bug please use the Bug issue type instead. Please see the Asterisk Issue Guidelines [1] for instruction on the intended use of the Asterisk issue tracker. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Kevin Harwell (kharwell) 2018-01-10 14:00:20.265-0600 [~pushkar.singh], Sounds like you have a pretty good idea as to a fix. That being the case, I'd highly recommend submitting a patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines [2] * Review the Code Review Checklist [3] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4] When ready, submit your patch and any tests to Gerrit [5] for code review. Thanks! [1] https://wiki.asterisk.org/wiki/display/AST/Code+Review [2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines [3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist [4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation [5] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Richard Mudgett (rmudgett) 2018-01-10 14:50:57.333-0600 Please be aware that a lot of the *active* analog handling code is not in chan_dahdi.c but in sig_analog.c.  sig_analog.c was extracted from chan_dahdi.c and unfortunately it was decided that sig_analog would not cover the radio operation.  I've occasionally wanted to remove all that duplicated code since we cannot really support the radio mode anymore and I really doubt the radio feature even works anymore.