Summary:	ASTERISK-27667: Commit 8082 - 'Prune subs with reliable transports at startup' causes sourcery/contact to fill up
Reporter:	Ross Beer (rossbeer)	Labels:	pjsip
Date Opened:	2018-02-11 04:51:48.000-0600	Date Closed:	2018-02-15 17:58:37.000-0600
Priority:	Major	Regression?	Yes
Status:	Closed/Complete	Components:	Resources/res_pjsip_pubsub
Versions:	GIT	Frequency of Occurrence	Constant
Related Issues:
Environment:	Fedora 21	Attachments:
Description:	Issue ASTERISK-27612 fixed subscriptions persisting after a reliable transport disconnected. However, on a restart, this process causes the 'sorcery/contact' task process to fill and stops PJSIP processing incoming SIP packets. Should the task processor for 'sourcery/contact' allow more entries or should subscription removal be handled in a different way?
Comments:	By: Asterisk Team (asteriskteam) 2018-02-11 04:51:49.593-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: George Joseph (gjoseph) 2018-02-12 09:43:53.964-0600 Hmmm.  removing a subscription shouldn't affect contact but I did have to change how contacts were pruned a bit.  I'm investigating. By: George Joseph (gjoseph) 2018-02-12 10:20:29.063-0600 Are you sure it was sorcery/contact that was overrun and not sorcery/subscription_persistence?  I'm not seeing anything in the code that could cause startup subscription pruning to affect contacts.  The code I changed was only related to how the prune_on_boot flag was being set for contacts. Can you check ps_contacts and make sure prune_on_boot is not being set for UDP contacts? By: Ross Beer (rossbeer) 2018-02-12 10:25:28.833-0600 prune_on_boot is set to 'no' for UDP contacts. I will re-run the restart when I have time to confirm the log output By: Ross Beer (rossbeer) 2018-02-15 17:58:22.393-0600 It appears that this issue only happens on the first reload. Please close the ticket.