[Home]

Summary:ASTERISK-27689: [patch] rtp_engine: Load format name / mime type in uppercase again.
Reporter:Alexander Traud (traud)Labels:patch
Date Opened:2018-02-17 08:43:24.000-0600Date Closed:2018-02-19 19:49:25.000-0600
Priority:MajorRegression?
Status:Closed/CompleteComponents:Core/RTP
Versions:13.12.0 15.0.0 Frequency of
Occurrence
Related
Issues:
Environment:3GPP EVS with Samsung GALAXY S7Attachments:( 0) upper_case_payload_format_name.patch
Description:Change [3360|http://gerrit.asterisk.org/3360] (commit [852e76|http://github.com/asterisk/asterisk/commit/852e7635719e4b217094786819df996816d82ab5]) made the symbol {{ast_rtp_engine_load_format(.)}} usable. That symbol allows the easy integration of new format modules, like the one for Codec 2 and other external ones like [mine|http://github.com/traud?tab=repositories&q=asterisk]. Instead of patching the file {{main/rtp_engine.c}} one can use {{ast_rtp_engine_load_format(.)}} directly within a transcoding module.

However, that change overdid it a bit by removing the upper-case of the payload format (encoding) name. Yes, [RFC 4855|http://tools.ietf.org/html/rfc4855#section-3] section 3 last paragraph states that this name shall be case-insensitive. Therefore, that change should not have any effect. However, in IETF RFCs and 3GPP TSs, that name is always shown in upper-case format. Therefore, some implementations are expecting the payload format name in upper-case. One such example is [documented for 3GPP EVS...|http://github.com/traud/asterisk-evs/issues/2]

Currently, in SIP SDP the name is printed in lower case. With a broken remote party, the format is not chosen which leads to reduced functionality, might lead to reduced quality and end even in no call establishment at all. Therefore, the attached patch reverses that part of the change and re-introduces upper-case again.

Within Asterisk, this affects only the audio codec Codec 2. All known Codec 2 implementations accept both lower- and upper-case.
Comments:By: Asterisk Team (asteriskteam) 2018-02-17 08:43:24.899-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Friendly Automation (friendly-automation) 2018-02-19 19:49:27.045-0600

Change 8251 merged by Jenkins2:
rtp_engine: Load format name / mime type in uppercase again.

[https://gerrit.asterisk.org/8251|https://gerrit.asterisk.org/8251]

By: Friendly Automation (friendly-automation) 2018-02-19 20:01:02.172-0600

Change 8252 merged by Jenkins2:
rtp_engine: Load format name / mime type in uppercase again.

[https://gerrit.asterisk.org/8252|https://gerrit.asterisk.org/8252]

By: Friendly Automation (friendly-automation) 2018-02-19 20:01:49.990-0600

Change 8250 merged by Jenkins2:
rtp_engine: Load format name / mime type in uppercase again.

[https://gerrit.asterisk.org/8250|https://gerrit.asterisk.org/8250]