Summary:	ASTERISK-27695: res_pjsip: local_net setting not updated on config reload
Reporter:	Jacek Konieczny (jkonieczny)	Labels:	pjsip
Date Opened:	2018-02-21 08:35:13.000-0600	Date Closed:	2018-03-12 10:14:41
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Resources/res_pjsip
Versions:	14.7.5 15.2.2	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	A change to {{local_net}} setting in {{pjsip.conf}} transport section is not reloaded on '{{reload res_pjsip}}', while '{{external_signaling_address}}' and '{{external_media_address}} ' are updated correctly. I have looked into the source code, but there seem to be a bit too much magic happening there for me to create a trivial patch. The problem seems to be that the '{{transport_localnet_handler()}}' function used to update this setting uses a different 'temporary state' object then is later used in '{{transport_apply}}' and actually applied to the transport.
Comments:	By: Asterisk Team (asteriskteam) 2018-02-21 08:35:14.062-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2018-02-21 08:40:50.485-0600 Asterisk 14 has not received bug fixes in quite some time. Please try a supported version, such as latest 13 or 15, and if this problem still exists then report back and update the affected version accordingly. By: Asterisk Team (asteriskteam) 2018-03-07 12:00:01.825-0600 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Jacek Konieczny (jkonieczny) 2018-03-12 08:35:52.641-0500 I have just tried with Asterisk 15.2.2. The problem is still there. Changes to local_net settings in pjsip.conf are ignored on res_pjsip reload. By: Asterisk Team (asteriskteam) 2018-03-12 08:35:52.983-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Joshua C. Colp (jcolp) 2018-03-12 09:51:34.666-0500 By default reloads of transports are not supported. They have to be turned on using the "allow_reload". If you do this do things change? I think allowing the changing of some configuration options without the option set would be reasonable though, albeit that would be a new feature. By: Jacek Konieczny (jkonieczny) 2018-03-12 10:09:28.850-0500 I was convinced that I did test it with 'allow_reload = true'… at least when I was testing this in Asterisk 14, but I could be confused by 'external_*_address' settings which do change even when 'allow_reload' is false. Anyway… on Asterisk 15.2.2 'allow_reload = true' local_net setting is updated as expected, so I guess this issue can be closed. I am sorry for the false alarm.