Summary:	ASTERISK-27697: Enable in-dialog NOTIFY on chan_pjsip channels
Reporter:	Nathan Bruning (nathanb)	Labels:	pjsip
Date Opened:	2018-02-22 12:50:21.000-0600	Date Closed:	2018-04-12 14:59:16
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_pjsip
Versions:	15.3.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	Broadsoft defines a call control protocol using SIP NOTIFY messages, which seems to be widely implemented; we've seen this working on SNOM phones, Yealink phones and Grandstream phones. For actions like 'answer', the phone needs to know which call to pickup, so the NOTIFY's are sent in-dialog. This patch adds support to send in-dialog SIP NOTIFY commands on chan_pjsip channels. Similar functionality has recently been added for chan_sip channels (ASTERISK-27461). We extend res_pjsip_notify to allow for in-dialog messages. A minor addition to res_pjsip is needed in order to fetch the active SIP dialog.
Comments:	By: Asterisk Team (asteriskteam) 2018-02-22 12:50:22.484-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: George Joseph (gjoseph) 2018-02-22 13:16:37.336-0600 Did you intend to attach a patch? By: Nathan Bruning (nathanb) 2018-02-22 13:25:46.868-0600 Yes, just submitted to Gerrit. By: Friendly Automation (friendly-automation) 2018-04-12 14:59:17.542-0500 Change 8766 merged by Jenkins2: res_pjsip_notify.c: enable in-dialog NOTIFY [https://gerrit.asterisk.org/8766|https://gerrit.asterisk.org/8766] By: Friendly Automation (friendly-automation) 2018-04-12 15:05:38.081-0500 Change 8765 merged by Jenkins2: res_pjsip_notify.c: enable in-dialog NOTIFY [https://gerrit.asterisk.org/8765|https://gerrit.asterisk.org/8765] By: Friendly Automation (friendly-automation) 2018-04-12 15:11:10.403-0500 Change 8374 merged by Jenkins2: res_pjsip_notify.c: enable in-dialog NOTIFY [https://gerrit.asterisk.org/8374|https://gerrit.asterisk.org/8374]