Summary:	ASTERISK-27715: [patch] BuildSystem: AC_PATH_PROG sets to colon character when not found.
Reporter:	Alexander Traud (traud)	Labels:	patch
Date Opened:	2018-03-05 03:27:54.000-0600	Date Closed:	2018-03-06 10:28:35.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	13.19.2 15.2.2	Frequency of Occurrence
Related Issues:
Environment:	NetBSD 7.1.1	Attachments:	( 0) detect_missing_tools.patch
Description:	NetBSD is one of those platforms which does not ship with the tool {{ldconfig}}. The script {{./configure}} checks correctly for its existence. The Makefile uses that finding not to call {{ldconfig}}. However, the authors of that code assumed the tool name would be empty. For those tools, not found by {{./configure}}, the name is set to a colon. The Makefile was scanned for more issues via the Regular Expression: {code} ifn?eq\s*\(\s*\$\s*\(\s*[A-Z0-9]*\s*\)\s*,\s*\){code}The tool {{awk}} is detected by {{AC_PROG_AWK}} and therefore is not a colon when not present. This affects those tools detected via {{AC_PATH_PROG}}. Therefore, only {{ldconfig}} and {{grep}} were affected. These two issues were introduced with [commit 92ef8a6|http://github.com/asterisk/asterisk/commit/92ef8a6fe1fe2adb79f1e928ffaf909e9afade67] and [commit 5bf283d|http://github.com/asterisk/asterisk/commit/5bf283d4060b2a8f90e347a42bbcfd40f5073942]. In case of the tool {{grep}}, another alternative would be to go for [{{AC_PROG_GREP}}|http://www.gnu.org/software/autoconf/manual/autoconf.html#Particular-Programs] instead of {{AC_PATH_PROG}}. With that, only the file {{third-party/pjproject/configure.m4}} would have to be changed, because that tests for a colon already. Similar was found by [~coreyfarrell] in [code review 8076|http://gerrit.asterisk.org/#/c/8076/] and re-reported for the tool {{ldconfig}} in [code review 7999|http://gerrit.asterisk.org/7999].
Comments:	By: Asterisk Team (asteriskteam) 2018-03-05 03:27:55.397-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-03-06 10:28:36.451-0600 Change 8420 merged by Jenkins2: BuildSystem: AC_PATH_PROG sets to colon character when not found. [https://gerrit.asterisk.org/8420|https://gerrit.asterisk.org/8420] By: Friendly Automation (friendly-automation) 2018-03-06 10:37:25.814-0600 Change 8418 merged by Jenkins2: BuildSystem: AC_PATH_PROG sets to colon character when not found. [https://gerrit.asterisk.org/8418|https://gerrit.asterisk.org/8418] By: Friendly Automation (friendly-automation) 2018-03-06 10:44:55.761-0600 Change 8419 merged by Jenkins2: BuildSystem: AC_PATH_PROG sets to colon character when not found. [https://gerrit.asterisk.org/8419|https://gerrit.asterisk.org/8419] By: Friendly Automation (friendly-automation) 2018-03-12 06:56:04.566-0500 Change 8467 merged by Jenkins2: BuildSystem regression: Fix errors reported by clean targets. [https://gerrit.asterisk.org/8467|https://gerrit.asterisk.org/8467] By: Friendly Automation (friendly-automation) 2018-03-12 08:49:38.317-0500 Change 8466 merged by Jenkins2: BuildSystem regression: Fix errors reported by clean targets. [https://gerrit.asterisk.org/8466|https://gerrit.asterisk.org/8466] By: Friendly Automation (friendly-automation) 2018-03-12 09:47:34.148-0500 Change 8465 merged by George Joseph: BuildSystem regression: Fix errors reported by clean targets. [https://gerrit.asterisk.org/8465|https://gerrit.asterisk.org/8465]