| Summary: | ASTERISK-27718: [patch] BuildSystem: Enable Lua in NetBSD. | ||
| Reporter: | Alexander Traud (traud) | Labels: | patch |
| Date Opened: | 2018-03-05 07:57:09.000-0600 | Date Closed: | 2018-03-12 07:47:55 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Core/BuildSystem |
| Versions: | 13.19.2 15.2.2 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | NetBSD 7.1.1 | Attachments: | ( 0) NetBSD_enable_lua.patch |
| Description: | Lua exists in several versions. The current version is 5.3. Asterisk started to leverage Lua with version 5.1. On some platforms, a default Lua exists, which is not pre/post-fixed with its version number in its path. For example in NetBSD:
* {{/usr/lib/liblua.so}} and * {{/usr/include/lua.h}}. In that case, the script {{./configure}} checks for the existence of the symbol {{luaL_openlib(.)}}. However, in recent versions of Lua, {{luaL_openlib(.)}} got removed. Therefore, {{./configure}} is not able to find Lua anymore. The trick is to use a symbol which is available in Lua 5.1, 5.2, and 5.3. {{luaL_newstate(.)}} is already used for those Lua installations with the version number in the path. No reason is known, why the very same symbol should not be used for the pre/post-fix less installations. Consequently, the attached patch goes for that approach. An even more smarter approach is discussed in ASTERISK-27638. However, for the start, this patch here is much easier. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-03-05 07:57:10.420-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-03-12 07:47:56.309-0500 Change 8429 merged by Jenkins2: BuildSystem: Enable Lua in NetBSD. [https://gerrit.asterisk.org/8429|https://gerrit.asterisk.org/8429] By: Friendly Automation (friendly-automation) 2018-03-12 09:04:18.728-0500 Change 8428 merged by Jenkins2: BuildSystem: Enable Lua in NetBSD. [https://gerrit.asterisk.org/8428|https://gerrit.asterisk.org/8428] By: Friendly Automation (friendly-automation) 2018-03-12 09:15:26.956-0500 Change 8427 merged by Jenkins2: BuildSystem: Enable Lua in NetBSD. [https://gerrit.asterisk.org/8427|https://gerrit.asterisk.org/8427] | ||