| Summary: | ASTERISK-27722: [patch] BuildSystem: Depend not implicitly but explicitly on external libraries. | ||
| Reporter: | Alexander Traud (traud) | Labels: | patch |
| Date Opened: | 2018-03-06 07:27:28.000-0600 | Date Closed: | 2018-03-12 07:09:28 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Core/BuildSystem Resources/res_odbc |
| Versions: | 13.19.2 15.2.2 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) odbc_explicit_depend.patch | |
| Description: | When an Asterisk module uses a symbol of an external library, it should declare is dependency explicitly. This avoids issues like in commit [eb0c9c4|http://github.com/asterisk/asterisk/commit/eb0c9c476f77701c693d68fe8d39508027b8f62f]. Furthermore, when that dependency is not declared explicitly, the created shared library does not load/link to that external library directly but via a dependency graph. That graph is created 'somehow' by the underlying platform and/or the load order and is therefore not reliable.
For example, while testing under NetBSD 7, my Run Path (rpath) was wrong. Consequently, five modules did not load because their implicit dependency was not fulfilled. They all use at least one SQL_ symbol. This created several dozen messages on the Command Line Interface (CLI) of Asterisk. This was confusing as it hid the actual issue, the wrong Run Path. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-03-06 07:27:28.601-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-03-12 07:09:31.441-0500 Change 8440 merged by Jenkins2: BuildSystem: Depend not implicitly but explicitly on external libraries. [https://gerrit.asterisk.org/8440|https://gerrit.asterisk.org/8440] By: Friendly Automation (friendly-automation) 2018-03-12 07:09:47.551-0500 Change 8439 merged by Jenkins2: BuildSystem: Depend not implicitly but explicitly on external libraries. [https://gerrit.asterisk.org/8439|https://gerrit.asterisk.org/8439] By: Friendly Automation (friendly-automation) 2018-03-12 07:12:27.022-0500 Change 8441 merged by Jenkins2: BuildSystem: Depend not implicitly but explicitly on external libraries. [https://gerrit.asterisk.org/8441|https://gerrit.asterisk.org/8441] | ||