Summary:	ASTERISK-27732: [patch] BuildSystem: Add the tool ftp to alternatively download external parts.
Reporter:	Alexander Traud (traud)	Labels:	patch
Date Opened:	2018-03-09 06:19:01.000-0600	Date Closed:	2018-03-17 08:11:56
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	13.19.2	Frequency of Occurrence
Related Issues:
Environment:	OpenBSD 6.2 NetBSD 7.1.1	Attachments:	( 0) NetBSD_enable_ftp.patch
Description:	The build system supports the tools wget, curl (mainly for macOS), and fetch (mainly for FreeBSD) to download external parts, for example the PJProject. On NetBSD and OpenBSD, the default tool for HTTP(s) downloads is called ftp. Beside adding ftp, the attached patch fixes the test for the variable DOWNLOAD_TO_STDOUT in the file {{third-party/pjproject/configure.m4}}, because that test expects an empty variable. However, that variable was never empty.
Comments:	By: Asterisk Team (asteriskteam) 2018-03-09 06:19:02.785-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Alexander Traud (traud) 2018-03-17 08:11:56.665-0500 OpenBSD and NetBSD use different tools, with incompatible parameters. I though I could rescue this change by going for the tool {{tnftp}}. However, neither OpenBSD nor NetBSD use this name/symlink to identify their ftp tool. Consequently, the solution would not have been generic but NetBSD (and OpenBSD) specific. Those specific changes can be done downstream by the port/package maintainers. Therefore, until I find a way to automatically identify the ftp tool variant, I am suspending this.