Summary:	ASTERISK-27742: res_monitor: Allow Monitor to Record Stereo
Reporter:	Sebastian Gutierrez (sum)	Labels:
Date Opened:	2018-03-15 08:27:09	Date Closed:	2018-03-19 07:52:15
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_monitor
Versions:	13.20.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	Add new option M to mix each participant of a call in a separate stereo channel I would like to put this on 13 because the change is trivial, this change allows speech analytic systems to be able to know who is who on a call. please let me know before I add a change on gerrit the version I should work with.
Comments:	By: Asterisk Team (asteriskteam) 2018-03-15 08:27:09.762-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Corey Farrell (coreyfarrell) 2018-03-15 09:25:35.482-0500 Is there any reason you implemented this in res_monitor instead of app_mixmonitor?  I ask because res_monitor will be deprecated in Asterisk 16.  This sounds like a nice feature and don't want to discourage the contribution but I worry about adding a feature to Monitor that is not available from MixMonitor (right now MixMonitor can do everything that Monitor can do). See ASTERISK-23657 for information about the motivations for deprecating res_monitor. By: Sebastian Gutierrez (sum) 2018-03-15 09:35:12.792-0500 adding in res_monitor is trivial because is done on the sox, is just to use sox with M instead of m, I have that already tested and working, as for mix monitor I was checking the code and as far as I can see Mixmonitor is using audiohooks like chan spy so I think the audio getting there is already in one stream? maybe Im wrong and someone can explain a bit how could this be done. By: Joshua C. Colp (jcolp) 2018-03-15 09:38:41.991-0500 It's up to the consumer of the audiohooks API, in this case MixMonitor, as to whether it wants things separate or mixed. By: Sebastian Gutierrez (sum) 2018-03-15 09:42:05.921-0500 as I didn´t know is deprecated this change is useless for monitor if someone can point me in the right direction for mixmonitor I will have a look at it, I think this is a very powerful feature that will attract people, google in there are many people asking for this kind of feature and doing workarounds with monitor, so in deprecation of monitor a lot of users will be affected because they wont be able to do this with MixMonitor. By: Corey Farrell (coreyfarrell) 2018-03-15 12:39:58.139-0500 This is outside of my area of knowledge but MixMonitor has options that allow recording receive and transmit to separate files (options 'r' and 't').  I suspect this would be a good start as it already handles each direction separately. By: Corey Farrell (coreyfarrell) 2018-03-15 12:42:42.797-0500 Also to answer your previous question about what branch to write for, new features always go into master.  Depending on risk, impact and testing it may be backported to 13/15 but I can't say for sure without seeing code. By: Joshua C. Colp (jcolp) 2018-03-19 05:36:29.571-0500 [~coreyfarrell] is correct - new features go into master. Things which include a test are eligible for placement into the release branches. I'm assigning this to you since it's waiting on you. By: Sebastian Gutierrez (sum) 2018-03-19 07:44:43.906-0500 Ok about going into master, but I don't think master is the way to go for Monitor app due to the deprecation, so you can close this issue, I will try to understand MixMonitor to see if there is a way to implement such a feature thanks By: Joshua C. Colp (jcolp) 2018-03-19 07:52:15.854-0500 Suspending per reporter.