Summary:	ASTERISK-27761: [patch] BuildSystem: With external editline, do not require libs for internal editline.
Reporter:	Alexander Traud (traud)	Labels:	patch
Date Opened:	2018-03-22 05:08:10	Date Closed:	2018-04-02 08:37:41
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:	13.20.0 15.3.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) libedit-13.patch ( 1) libedit-16.patch
Description:	In Asterisk, libedit is a basic/essential requirement. ASTERISK-18725 allows an external libedit, the copy of the platform. However, that change was not complete: Libraries required for the internal libedit were still checked. Those libraries remained basic/essential for the whole Asterisk, even then when an external libedit is available. The solution is to check for the external libedit before the libraries for the internal libedit. And to check for those libraries only when the internal libedit is going to be used. Finally, re-checks for an alternative library (for the required libedit) are done only when the previous check failed. This avoids up-to four unnecessary checks. ASTERISK-27634 removed the internal libedit for the upcoming Asterisk 16. However, that change was not complete: The build system still checked for libraries required for an internal libedit. That is a follow-up issue of the one above because that relationship between external libedit and libraries required for an internal libedit was not obvious. This avoids four unnecessary checks. For both issues, no real-world effects are known, because the other essential requirements of Asterisk (libxml2) depend at least on one of those libraries required for an internal libedit. However, on some platforms, like openSUSE Leap, the error message printed by the script {{./configure}} asked for such an library erroneously.
Comments:	By: Asterisk Team (asteriskteam) 2018-03-22 05:08:12.925-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-04-02 08:37:42.933-0500 Change 8628 merged by Jenkins2: BuildSystem: With external editline, do not require libs for internal editline. [https://gerrit.asterisk.org/8628|https://gerrit.asterisk.org/8628] By: Friendly Automation (friendly-automation) 2018-04-02 08:43:44.212-0500 Change 8629 merged by Joshua Colp: BuildSystem: With external editline, do not require libs for internal editline. [https://gerrit.asterisk.org/8629|https://gerrit.asterisk.org/8629] By: Friendly Automation (friendly-automation) 2018-04-02 08:47:09.685-0500 Change 8630 merged by Jenkins2: BuildSystem: With external editline, do not require libs for internal editline. [https://gerrit.asterisk.org/8630|https://gerrit.asterisk.org/8630]