Summary:	ASTERISK-27796: res_hep: Allow create_address to resolve a provided hostname
Reporter:	Sebastian Gutierrez (sum)	Labels:
Date Opened:	2018-04-09 10:43:10	Date Closed:	2018-05-09 18:53:47
Priority:	Trivial	Regression?
Status:	Closed/Complete	Components:	Resources/res_hep
Versions:	15.3.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	When using dns name on hep.conf  with capture_address = hep:9061 result is WARNING[6872]: res_hep.c:383 hepv3_data_alloc: Failed to create address from hep:9061 should be using ast_getbyhostname to be able to resolve dns.
Comments:	By: Asterisk Team (asteriskteam) 2018-04-09 10:43:10.788-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2018-04-10 08:45:49.393-0500 Do you plan on providing a patch for this? If so the process for contributing it is linked in the first comment. By: Sebastian Gutierrez (sum) 2018-04-10 08:51:30.736-0500 I leave this here to remember a cannot provide a patch right now but will in the future, I actually started but had some issue with   hp = ast_gethostbyname(config->capture_address, &he); I will try to get back to it as soon as I can, but as this could be trivial for someone that implemented this on other modules I opened the issue. I will add here if I start on the patch If is not done by that time By: Joshua C. Colp (jcolp) 2018-04-10 08:54:17.990-0500 You should probably be using ast_sockaddr_resolve instead. By: Matthew Fredrickson (mattf) 2018-05-04 16:37:03.982-0500 I just posted a patch that hopefully resolves this issue.  Can you verify that it works for you? By: Sebastian Gutierrez (sum) 2018-05-06 09:30:13.241-0500 seems to load ok, no more errors By: Matthew Fredrickson (mattf) 2018-05-08 16:53:32.706-0500 Great!  If you feel comfortable enough to do a code review on it, that would be much appreciated. Thanks! Matt By: Friendly Automation (friendly-automation) 2018-05-09 18:53:48.247-0500 Change 8953 merged by Joshua Colp: res_hep: Adds hostname resolution support for capture_address [https://gerrit.asterisk.org/8953|https://gerrit.asterisk.org/8953] By: Friendly Automation (friendly-automation) 2018-05-09 19:01:19.297-0500 Change 8954 merged by Joshua Colp: res_hep: Adds hostname resolution support for capture_address [https://gerrit.asterisk.org/8954|https://gerrit.asterisk.org/8954] By: Friendly Automation (friendly-automation) 2018-05-09 19:01:36.407-0500 Change 8932 merged by Joshua Colp: res_hep: Adds hostname resolution support for capture_address [https://gerrit.asterisk.org/8932|https://gerrit.asterisk.org/8932]