| Summary: | ASTERISK-27798: CDR_PROP(party_a) does not work. | ||
| Reporter: | Jeff Hoppe (jhoppebugs) | Labels: | |
| Date Opened: | 2018-04-12 12:03:31 | Date Closed: | 2021-11-03 13:04:24 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | CDR/General |
| Versions: | 13.20.0 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | CDR_PROP(party_a) doesn't work. I traced the code to main/cdr.c source file.
The function that determines which CDR is party A has two cdr snapshots as parameters. The code is written where if the party_a flag was set on the second cdr snapshot (right), it will be ignored. Function showing in reference notes below. This line (which will always be false): } else if (!ast_test_flag(right, AST_CDR_FLAG_PARTY_A) && ast_test_flag(right, AST_CDR_FLAG_PARTY_A)) { . should be . } else if (!ast_test_flag(left, AST_CDR_FLAG_PARTY_A) && ast_test_flag(right, AST_CDR_FLAG_PARTY_A)) { if I am not mistaken. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-04-12 12:03:32.499-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Kevin Harwell (kharwell) 2018-04-12 18:23:14.736-0500 It looks like you are correct. It appears to be a easy fix. Any interest in submitting a patch to gerrit? By: Jeff Hoppe (jhoppebugs) 2018-04-13 10:53:11.782-0500 I have never done that before. I will research what steps I need to do and give it a try. By: Kevin Harwell (kharwell) 2018-04-13 14:12:16.546-0500 [~jhoppebugs] Sounds good! Please let us know if you have any questions about submitting a patch. By: Sean Bright (seanbright) 2021-11-03 13:04:24.345-0500 Fixed by https://gerrit.asterisk.org/c/asterisk/+/16152 | ||