Summary: | ASTERISK-27874: [patch] tcptls: Allow OpenSSL 1.1.x configured with enable-ssl3-method no-deprecated. | ||
Reporter: | Alexander Traud (traud) | Labels: | patch |
Date Opened: | 2018-05-25 07:08:09 | Date Closed: | 2018-06-05 13:02:12 |
Priority: | Major | Regression? | |
Status: | Closed/Complete | Components: | Core/General |
Versions: | 13.21.0 15.4.0 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ( 0) 13_extra_defined.patch ( 1) 15_extra_defined.patch | |
Description: | OpenSSL can be configured (and then built) in various combinations. The _easiest_ (?) way to find the relevant configuration, is to look-up each used symbol and check the surrounding Defines in the header file of OpenSSL. If one of the guards is missing (or is a combination of several ones) and OpenSSL was built with that, Asterisk is not going to compile.
{{SSLv3_client_method()}} is guarded by {{OPENSSL_NO_SSL3_METHOD}} and {{OPEN_API_COMPAT}}. Consequently, Asterisk does not build, if a OpenSSL 1.1.x was built via {code}./config enable-ssl3-method no-deprecated make{code}The attached patch fixes this. Additionally, that patch removes {{defined(OPENSSL_VERSION_NUMBER)}} because that is a left-over from commit [2c8d076|https://github.com/asterisk/asterisk/commit/2c8d0764de87037ce52656e13b36de5d9876aeaa]. Finally, the patch moves {{LIBRESSL_VERSION_NUMBER}} to first position because LibreSSL changed its {{OPENSSL_VERSION_NUMBER}} several times. | ||
Comments: | By: Asterisk Team (asteriskteam) 2018-05-25 07:08:11.183-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-06-05 13:02:13.771-0500 Change 9053 merged by George Joseph: tcptls: Allow OpenSSL 1.1.x configured with enable-ssl3-method no-deprecated. [https://gerrit.asterisk.org/9053|https://gerrit.asterisk.org/9053] By: Friendly Automation (friendly-automation) 2018-06-05 13:02:36.263-0500 Change 9051 merged by George Joseph: tcptls: Allow OpenSSL 1.1.x configured with enable-ssl3-method no-deprecated. [https://gerrit.asterisk.org/9051|https://gerrit.asterisk.org/9051] By: Friendly Automation (friendly-automation) 2018-06-05 13:03:08.714-0500 Change 9052 merged by George Joseph: tcptls: Allow OpenSSL 1.1.x configured with enable-ssl3-method no-deprecated. [https://gerrit.asterisk.org/9052|https://gerrit.asterisk.org/9052] |