Summary:	ASTERISK-27893: testsuite: Current version of the Python module construct is incompatible.
Reporter:	Alexander Traud (traud)	Labels:	patch pjsip
Date Opened:	2018-06-04 06:29:19	Date Closed:	2018-06-19 04:34:53
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Tests/testsuite
Versions:	GIT	Frequency of Occurrence
Related Issues:
Environment:	python-construct 2.8 and newer	Attachments:	( 0) suite_construct.patch
Description:	Since version 2.6 (Sep. 2016), the Python module {{construct}} is [not forward compatible|http://construct.readthedocs.io/en/stable/transition28.html]. Version 2.8 was the first stable release with that new API. That version gets installed in Ubuntu 18.04 LTS. Therefore, several tests in the Asterisk Test Suite fail. {{exceptions.NameError: global name 'BitField' is not defined}} is raised by tests/channels/pjsip/rtp/rtp_keepalive/base. {{ImportError: No module named protocols.ipstack}} is raised by tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media tests/channels/pjsip/subscriptions/rls/lists_of_lists/off_nominal/presence/shared_name_w_list_support tests/channels/pjsip/subscriptions/rls/lists_of_lists/off_nominal/presence/resource_duplication tests/channels/pjsip/subscriptions/rls/lists_of_lists/off_nominal/mwi/shared_name_w_list_support tests/channels/pjsip/subscriptions/rls/lists_of_lists/off_nominal/mwi/resource_duplication tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/termination_full_state tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/resubscribe_full_state tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/partial_state_carol tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/listception_initial_notify tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/initial_notify tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/full_state_carol tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/full_state_alice tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/presence/batched tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/termination_full_state tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/resubscribe_full_state tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_carol tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/partial_state_alice tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/initial_notify tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_carol tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/full_state_alice tests/channels/pjsip/subscriptions/rls/lists_of_lists/nominal/mwi/batched tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/some_list_resources_exist tests/channels/pjsip/subscriptions/rls/lists/off_nominal/presence/resource_duplication tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/some_list_resources_exist tests/channels/pjsip/subscriptions/rls/lists/off_nominal/mwi/resource_duplication tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/termination_full_state tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/resubscribe_full_state tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/partial_state tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/batched/termination_interruption tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/batched/resubscription_interruption tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/batched/multiple_resources_single_change tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/batched/basic tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/termination_full_state tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/resubscribe_full_state tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/partial_state tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/initial_notify tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/full_state tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/batched/termination_interruption tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/batched/single_resource_multiple_changes tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/batched/resubscription_interruption tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/batched/multiple_resources_single_change tests/channels/pjsip/subscriptions/rls/lists/nominal/mwi/batched/basic tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_xpidf tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf *Workaround* The attached patch is just a workaround. You get that additional module by going for {{sudo apt install python-construct.legacy}}.
Comments:	By: Asterisk Team (asteriskteam) 2018-06-04 06:29:21.060-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].