Summary:	ASTERISK-27899: res_pjsip: XMPP Status to OpenFire incorrect after OPTIONs rewrite
Reporter:	Ross Beer (rossbeer)	Labels:	pjsip
Date Opened:	2018-06-05 10:15:35	Date Closed:	2018-06-27 04:24:04
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_pjsip Resources/res_xmpp
Versions:	13.21.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	CentOS 7	Attachments:
Description:	The res_xmpp module status published to OpenFire has changed since the following commit: https://gerrit.asterisk.org/#/c/7710/ The status is set to 'Unknown' instead of the previous value of 'Available'. Rolling back the commit resolves the issue. The chan_pjsip configuration does not qualify the contact and therefore the endpoint shows as follows: {noformat} Endpoint:  <<ENDPOINT>>/<<ENDPOINT>>                                Unavailable   0 of inf     InAuth:  <<ENDPOINT>>/<<ENDPOINT>>        Aor:  <<ENDPOINT>>                                          1      Contact:  <<ENDPOINT>>/sip:<<CONTACT>> 559a5583df Unknown         nan {noformat}
Comments:	By: Asterisk Team (asteriskteam) 2018-06-05 10:15:36.648-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Sean Bright (seanbright) 2018-06-25 13:07:52.644-0500 So is this really a {{res_xmpp}} problem or is the difference what PJSIP is reporting for an unqualified contact before and after the patch? By: Ross Beer (rossbeer) 2018-06-25 13:25:33.078-0500 I don't think it is res_xmpp, but as you say the reported status is different since the OPTIONS ping patch has been added. By: Sean Bright (seanbright) 2018-06-25 13:48:44.045-0500 Can you share enough of your PJSIP configuration that I can reproduce this? By: Richard Mudgett (rmudgett) 2018-06-25 13:49:41.171-0500 Which branch is this issue against? By: Ross Beer (rossbeer) 2018-06-25 13:53:37.122-0500 Its the 13 GIT branch and if you don't set a qualify the endpoint is set to 'Unknown' as I believe it should be. Its the unknown status that is now carried through XMPP whereas before the patch the endpoints would show Available. By: Sean Bright (seanbright) 2018-06-25 15:43:04.316-0500 Can you please attach a capture of the relevant XMPP packets from before the patch and from after? By: Ross Beer (rossbeer) 2018-06-27 03:56:19.368-0500 I've been thinking about this after the chat on IRC, can you please close the ticket. Even though this is a behaviour change, I believe it is the correct behaviour.