| Summary: | ASTERISK-27931: [patch] BuildSystem: Enable ./configure in Solaris 11. | ||||
| Reporter: | Alexander Traud (traud) | Labels: | patch | ||
| Date Opened: | 2018-06-21 03:18:37 | Date Closed: | 2018-06-22 08:43:13 | ||
| Priority: | Minor | Regression? | |||
| Status: | Closed/Complete | Components: | Core/BuildSystem | ||
| Versions: | 13.21.1 15.4.1 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Solaris 11.3 | Attachments: | ( 0) solaris_raii.patch | ||
| Description: | To avoid any confusion: Solaris 11 is a platform [not supported officially|http://lists.digium.com/pipermail/asterisk-dev/2018-January/076770.html] but relies on contributions from the community. This patch here is part of a series to get Asterisk going on the latest Oracle Solaris. Or stated differently: Much more must be done, to get Asterisk working there. Let us tackle this one after another.
This issues was caused by Commit [29304d1|http://github.com/asterisk/asterisk/commit/29304d10a0981fddf020b0c8655d041d3f15960f#diff-67e997bcfdac55191033d57a16d1408a] (ASTERISK-20850). The problem is the use of double-quotes within backticks within double-quotes. Some shell parsers like the one of Solaris 11, do not match the backticks but stop on double-quote. The parser thinks the quote ended after {{`echo}}. The rest is then executed on the shell, which creates chaos. On the Stack Exchange network, a lot of discussions exists how to tackle this: [387246|http://unix.stackexchange.com/q/387246]. My approach are single-quotes as inner quotes because their content is needed literally. As a side-effect that helps the parser not to end the initial quote. That approach is taken in the attached patch. Normally, single-quotes within double-quotes [lose their meaning|http://unix.stackexchange.com/a/169512]. However, the single-quotes are within backticks and evaluated as 'usual'. Other approaches would have been: * replace backticks with {{$(...)}} and/or * replace the double-quotes with test -n or test -z. | ||||
| Comments: | By: Asterisk Team (asteriskteam) 2018-06-21 03:18:39.643-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-06-22 08:43:15.008-0500 Change 9245 merged by Jenkins2: BuildSystem: Enable ./configure in Solaris 11. [https://gerrit.asterisk.org/9245|https://gerrit.asterisk.org/9245] By: Friendly Automation (friendly-automation) 2018-06-22 09:09:06.323-0500 Change 9246 merged by Jenkins2: BuildSystem: Enable ./configure in Solaris 11. [https://gerrit.asterisk.org/9246|https://gerrit.asterisk.org/9246] By: Friendly Automation (friendly-automation) 2018-06-22 09:23:21.961-0500 Change 9240 merged by George Joseph: BuildSystem: Enable ./configure in Solaris 11. [https://gerrit.asterisk.org/9240|https://gerrit.asterisk.org/9240] | ||||