ASTERISK-27937: build: POSIX does not know sed -i

[Home]

Summary: ASTERISK-27937: build: POSIX does not know sed -i

Reporter: Alexander Traud (traud) Labels:

Date Opened: 2018-06-23 01:06:59 Date Closed:

Priority: Minor Regression?

Status: Open/New Components: Core/BuildSystem

Versions: 13.21.1 15.4.1 Frequency of
Occurrence

Related
Issues:

Environment: Attachments:

Description: In the current Asterisk, the command-line tool {{sed}} is used with the parameter {{-i}}. That parameter is not known in POSIX. Therefore, the command fails in several shells, like the one of Solaris 11.

Thanks to the Regular Expression {{sed -(.* -)?i}}, I found that usage in:
* Makefile (Commit [efd040c|http://github.com/asterisk/asterisk/commit/efd040cd11cff99a9dccf54c030a134d9a1e2e07#diff-b67911656ef5d18c4ae36cb6741b7965]; Jul 2011)
* contrib/docker/make-package.sh (Commit [0da36fc|http://github.com/asterisk/asterisk/commit/0da36fca6bfc2c9af076f0728e718cef05c9bac8#diff-7c3adc5d6745a712b8a929ad63a9376b]; Feb. 2016)
* contrib/scripts/ast_logescalator (Commit [ef4deb8|http://github.com/asterisk/asterisk/commit/ef4deb8ecd52a3c0b0952badc6ec0e5e48231011#diff-273c3b0a52c2dd4eaa0df0b5993127a9]; Jan. 2017)
* contrib/scripts/get_mp3_source.sh (Commit [37179a2|http://github.com/asterisk/asterisk/commit/37179a2b1f0a12e063a2bb300e402ac5e7512569#diff-1ed46266ee75041733d09cdf2ecdc045], ASTERISK-24348; Sep. 2014)
* contrib/scripts/live_ast (Commit [e98ee36|http://github.com/asterisk/asterisk/commit/e98ee36c0f7c5026fa672ebd142387076f8636d8], ASTERISK-11152; Oct. 2008)
* contrib/scripts/live_ast (Commit [1ede3c3|http://github.com/asterisk/asterisk/commit/1ede3c3ca62fbe5ec3dc1c902de3f901febbb1a9], ASTERISK-14054; Sep. 2009)

Are you a shell wizard? Then, please, fix those places. An approach is discussed on the [Stack Exchange network...|http://unix.stackexchange.com/a/92907] (very last example).

Comments: By: Asterisk Team (asteriskteam) 2018-06-23 01:07:01.446-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].