[Home]

Summary:ASTERISK-27945: TCP-Peer with insecure=port not found on incoming call
Reporter:Olaf Holthausen (oholthau)Labels:
Date Opened:2018-06-26 02:31:48Date Closed:2018-06-27 04:26:58
Priority:MajorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/General Channels/chan_sip/TCP-TLS
Versions:13.21.1 15.4.1 Frequency of
Occurrence		Constant
Related
Issues:
duplicatesASTERISK-27881 PBX calls via chan_sip TCP trunk now get authentification error
Environment:Unbuntu 14.04Attachments:
Description:A TCP peer with insecure=port is not found on incoming call if the port is not the same as defined in port=XXX.
in chan_sip.c, function peer_ipcmp_cb_full, the TCP and TLS transports needs to be added in the if statement. Then it works.
Before:
       if (((peer->transports & peer2->transports) &
               (AST_TRANSPORT_UDP | AST_TRANSPORT_WS | AST_TRANSPORT_WSS)) &&
               ast_test_flag(&peer2->flags[0], SIP_INSECURE_PORT)) {
               /* We are allowing match without port for peers configured that
                * way in this pass through the peers. */
               return ast_test_flag(&peer->flags[0], SIP_INSECURE_PORT) ?
                               (CMP_MATCH | CMP_STOP) : 0;
       }

After:
       if (((peer->transports & peer2->transports) &
               (AST_TRANSPORT_UDP | AST_TRANSPORT_TCP | AST_TRANSPORT_TLS | AST_TRANSPORT_WS | AST_TRANSPORT_WSS)) &&
               ast_test_flag(&peer2->flags[0], SIP_INSECURE_PORT)) {
               /* We are allowing match without port for peers configured that
                * way in this pass through the peers. */
               return ast_test_flag(&peer->flags[0], SIP_INSECURE_PORT) ?
                               (CMP_MATCH | CMP_STOP) : 0;
       }
Comments:By: Asterisk Team (asteriskteam) 2018-06-26 02:31:50.570-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].