| Summary: | ASTERISK-27961: res_pjsip: Spurious ERROR logging when printing headers in sip_msg | ||
| Reporter: | Nick French (naf) | Labels: | pjsip |
| Date Opened: | 2018-07-13 09:24:52 | Date Closed: | 2018-07-18 05:48:07 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | pjproject/pjsip |
| Versions: | 13.22.0 15.5.0 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Asterisk patches the pjproject source to avoid crashing when pjproject sip_msg headers are encountered with NULL vptr's. This logic is correct.
However, in the same patch, error logging was added to announce when these NULL-vtpr headers were seen, but the logic of the logging is to mark an error for every printed header that results in no header text being added to the sip msg, not just when an actual NULL vptr is encountered. There exists types of headers that are perfectly valid yet result in no header text being added to the sip msg, such as a 'hidden' Route header. These types should not be treated as an error. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-07-13 09:24:53.495-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Richard Mudgett (rmudgett) 2018-07-13 11:27:41.504-0500 The 0060-sip_msg-Prevent-crash-on-header-without-vptr.patch file in the asterisk code base is not the patch that actually got committed into pjproject's code base in svn -r5727. To fix the issue it looks like we just need to replace that patch file with the patch that got committed to pjproject instead. By: Friendly Automation (friendly-automation) 2018-07-18 05:48:08.406-0500 Change 9484 merged by Joshua Colp: res_pjsip: Remove spurious error logging when printing silent headers [https://gerrit.asterisk.org/9484|https://gerrit.asterisk.org/9484] By: Friendly Automation (friendly-automation) 2018-07-18 05:50:27.536-0500 Change 9483 merged by Joshua Colp: res_pjsip: Remove spurious error logging when printing silent headers [https://gerrit.asterisk.org/9483|https://gerrit.asterisk.org/9483] By: Friendly Automation (friendly-automation) 2018-07-18 05:50:50.389-0500 Change 9485 merged by Joshua Colp: res_pjsip: Remove spurious error logging when printing silent headers [https://gerrit.asterisk.org/9485|https://gerrit.asterisk.org/9485] | ||