Summary:	ASTERISK-27995: pjproject_bundled: Find shared libraries in root --with-ssl=PATH.
Reporter:	Alexander Traud (traud)	Labels:	patch
Date Opened:	2018-07-30 06:01:28	Date Closed:	2018-08-06 05:30:14
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	pjproject/pjsip
Versions:	13.22.0 15.5.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 0110-configure-ssl-library-path.patch
Description:	The script {{configure}} from Teluu expects shared libraries (.so) in a subfolder called {{./lib}}, when {{--with-xyz=PATH}} is specified. However for OpenSSL, the default location is {{./}} (root) of the source folder = PATH. Furthermore in Asterisk, the script {{configure}} supports both: * {{./lib}} * {{./}} For consistency and because Asterisk is using (only) OpenSSL in PJProject, the attached patch allows both locations, just like Asterisk. To avoid the need for the tool autoconf, not only {{configure.ac}} but the script {{configure}} directly was changed as well. Note: This change was rejected by Teluu, because it addressed only one library, the only external library which Asterisk is using in PJProject. Changing all libraries to lib+root like in Asterisk was rejected as well (why ever). However, that means this patch is not remove with the next PJProject release but is going to stay forever.
Comments:	By: Asterisk Team (asteriskteam) 2018-07-30 06:01:31.410-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-08-06 05:30:16.031-0500 Change 9774 merged by Joshua Colp: pjproject_bundled: Find shared libraries in root --with-ssl=PATH. [https://gerrit.asterisk.org/9774|https://gerrit.asterisk.org/9774] By: Friendly Automation (friendly-automation) 2018-08-06 05:30:25.637-0500 Change 9777 merged by Joshua Colp: pjproject_bundled: Find shared libraries in root --with-ssl=PATH. [https://gerrit.asterisk.org/9777|https://gerrit.asterisk.org/9777] By: Friendly Automation (friendly-automation) 2018-08-06 05:30:35.088-0500 Change 9775 merged by Joshua Colp: pjproject_bundled: Find shared libraries in root --with-ssl=PATH. [https://gerrit.asterisk.org/9775|https://gerrit.asterisk.org/9775] By: Friendly Automation (friendly-automation) 2018-08-06 05:30:43.087-0500 Change 9776 merged by Joshua Colp: pjproject_bundled: Find shared libraries in root --with-ssl=PATH. [https://gerrit.asterisk.org/9776|https://gerrit.asterisk.org/9776]