Summary: | ASTERISK-28002: When T.140 realtime text is negociated, a lot of debug traces are generated | ||
Reporter: | Emmanuel BUU (neutrino88) | Labels: | |
Date Opened: | 2018-08-03 04:49:25 | Date Closed: | 2018-08-28 09:15:07 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Resources/res_rtp_asterisk |
Versions: | 13.22.0 | Frequency of Occurrence | Constant |
Related Issues: | |||
Environment: | Cent OS 7 - | Attachments: | |
Description: | If we process a call with T.140/RED and activate debug traces
core set debug 1 We get a constant flow of traces: Received frame with no data for RTP instance 'xxxx' so dropping frame We propose the follwing simple fix in res_rtp_asterisk.c In : {code:title=res_rtp_asterisk.c} static int red_write(const void *data) { struct ast_rtp_instance *instance = (struct ast_rtp_instance*) data; struct ast_rtp *rtp = ast_rtp_instance_get_data(instance); ao2_lock(instance); ast_rtp_write(instance, &rtp->red->t140); ao2_unlock(instance); return 1; } {code} Correct the line {code:title=res_rtp_asterisk.c} if (rtp->red->t140.datalen > 0) { ast_rtp_write(instance, &rtp->red->t140); } {code} | ||
Comments: | By: Asterisk Team (asteriskteam) 2018-08-03 04:49:27.318-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Richard Mudgett (rmudgett) 2018-08-03 11:56:47.831-0500 Will you be submitting a patch? By: Asterisk Team (asteriskteam) 2018-08-17 12:00:01.912-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines By: Emmanuel BUU (neutrino88) 2018-08-21 08:05:44.498-0500 Posted a patch. By: Asterisk Team (asteriskteam) 2018-08-21 08:05:44.824-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Friendly Automation (friendly-automation) 2018-08-28 09:15:09.020-0500 Change 10007 merged by George Joseph: res/res_rtp_asterisk: remove debug traces generated by an empty frame [https://gerrit.asterisk.org/10007|https://gerrit.asterisk.org/10007] By: Friendly Automation (friendly-automation) 2018-08-28 09:15:34.216-0500 Change 10008 merged by George Joseph: res/res_rtp_asterisk: remove debug traces generated by an empty frame [https://gerrit.asterisk.org/10008|https://gerrit.asterisk.org/10008] By: Friendly Automation (friendly-automation) 2018-08-28 09:15:55.986-0500 Change 9979 merged by George Joseph: res/res_rtp_asterisk: remove debug traces generated by an empty frame [https://gerrit.asterisk.org/9979|https://gerrit.asterisk.org/9979] By: Friendly Automation (friendly-automation) 2018-08-28 09:16:22.800-0500 Change 10009 merged by George Joseph: res/res_rtp_asterisk: remove debug traces generated by an empty frame [https://gerrit.asterisk.org/10009|https://gerrit.asterisk.org/10009] |