Summary:	ASTERISK-28005: channel.c: ARI ring only once
Reporter:	Hajek Michal (hajekmi)	Labels:	patch
Date Opened:	2018-08-07 08:24:45	Date Closed:	2018-09-07 07:03:02
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Core/General
Versions:	15.4.0 15.5.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	CentOS release 6.9	Attachments:	( 0) ari_ringing_fix.patch ( 1) full_ringingfixed.txt ( 2) full_ringingissue.txt
Description:	There is some issue when making request ari/ring on answered channel. Steps I use to reproduce: 1. call from SIP/322 to Stasis app 2. in Stasis app making requests: answer, create bridge, add channel to bridge and originate channel SIP/611 (after dial goto Stasis app). 3. second channel SIP/611 arrive to same Stasis app and add channel to bridge 4. situation: SIP/322 -->bridge<-- SIP/611 5. on first channel SIP/322 making requests hold and mute (ari) 6. *bug* on second channel SIP/611 making request ring - a hear only once ringing tone. There is no ringing tone repeatedly. On asterisk 15.3.0 this bug not reflected. I found a commit who broke it https://github.com/asterisk/asterisk/commit/ad3a8dc49710b6ac9b6ece2953fa8b39dccfeb0d#diff-43bfdcf1afb13c834cbfa2aff372eabe I tried writing patch for asterisk 15.4.0 and 15.5.0, can you verify?
Comments:	By: Asterisk Team (asteriskteam) 2018-08-07 08:24:46.618-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Richard Mudgett (rmudgett) 2018-08-09 11:17:40.908-0500 * How are you originating the call for SIP/611? * In step 6 who is hearing the ringback?  SIP/611? * The patch is only reverting part of the identified commit.  You are reverting code that passes an AST_FRAME_RTCP frame to the core which effectively disables the purpose of the identified commit so it is not an acceptable solution.  However, does your patch "fix" the issue for you? By: Hajek Michal (hajekmi) 2018-08-13 07:14:02.852-0500 Channel SIP/611 create from POST /ari/channels (body contains endpoint and stasis name app with arg). Channel SIP/611 is hearing ringback (hear only once, then silent). Yes, this patch resolve this situation. By: Benjamin Keith Ford (bford) 2018-08-14 09:42:53.123-0500 [~hajekmi], would you like to submit your patch to Gerrit [1]? Many developers will be able to look at your patch and review it here, helping to get it merged into the code base. A full guide on how to get started with Gerrit can be found here [2]. As Richard said, the patch in its current state won't be acceptable as a solution, but if you would like to work on another solution, this would be the process to follow to get feedback and any help you may need to resolve the issue. [1] https://gerrit.asterisk.org/#/q/status:open [2] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Friendly Automation (friendly-automation) 2018-09-07 07:03:03.878-0500 Change 10050 merged by Jenkins2: core: Don't stop generators when writing RTCP frames. [https://gerrit.asterisk.org/10050|https://gerrit.asterisk.org/10050] By: Friendly Automation (friendly-automation) 2018-09-07 07:03:16.506-0500 Change 10051 merged by Jenkins2: core: Don't stop generators when writing RTCP frames. [https://gerrit.asterisk.org/10051|https://gerrit.asterisk.org/10051] By: Friendly Automation (friendly-automation) 2018-09-07 07:05:18.270-0500 Change 10049 merged by Jenkins2: core: Don't stop generators when writing RTCP frames. [https://gerrit.asterisk.org/10049|https://gerrit.asterisk.org/10049]