Summary: | ASTERISK-28022: res_pjsip realtime: uri column in ps_contacts table can be too short | ||
Reporter: | Florian Floimair (f.floimair) | Labels: | pjsip |
Date Opened: | 2018-08-23 06:41:08 | Date Closed: | 2018-08-28 09:17:13 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Resources/res_pjsip |
Versions: | 13.22.0 15.5.0 16.0.0 | Frequency of Occurrence | Constant |
Related Issues: | |||
Environment: | Debian 9.5 "stretch" | Attachments: | |
Description: | When mobile SIP clients register with Asterisk that use some sort of push notifications, the URI can get quite lengthy due to the additional push-service annotations (things like tokens, pn-type, etc.) contained in it.
The current uri column in ps_contacts is 255 characters, but we have seen instances with Android devices (that have very long tokens) where the resulting URI was actually up to 280 characters long. As a result, the URI is truncated to the 255 characters allowed and outgoing calls to the endpoint are failing. Also re-registrations of the client do not match the previous contact entry since the comparison cannot result to "equal". I have prepared an alembic script that extends the uri column to twice the size. | ||
Comments: | By: Asterisk Team (asteriskteam) 2018-08-23 06:41:11.147-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-08-28 09:17:14.115-0500 Change 9996 merged by George Joseph: alembic: increase uri column size [https://gerrit.asterisk.org/9996|https://gerrit.asterisk.org/9996] By: Friendly Automation (friendly-automation) 2018-08-28 09:18:06.006-0500 Change 9994 merged by George Joseph: alembic: increase uri column size [https://gerrit.asterisk.org/9994|https://gerrit.asterisk.org/9994] By: Friendly Automation (friendly-automation) 2018-08-28 17:35:47.759-0500 Change 9993 merged by Jenkins2: alembic: increase uri column size [https://gerrit.asterisk.org/9993|https://gerrit.asterisk.org/9993] By: Friendly Automation (friendly-automation) 2018-08-29 05:20:36.215-0500 Change 9995 merged by Joshua Colp: alembic: increase uri column size [https://gerrit.asterisk.org/9995|https://gerrit.asterisk.org/9995] By: Friendly Automation (friendly-automation) 2018-08-29 06:09:44.229-0500 Change 10014 merged by Joshua Colp: alembic: increase uri column size [https://gerrit.asterisk.org/10014|https://gerrit.asterisk.org/10014] |